diff options
| author | Ezequiel Garcia <ezequiel@vanguardiasur.com.ar> | 2014-09-02 09:51:21 -0300 |
|---|---|---|
| committer | Dave Airlie <airlied@redhat.com> | 2014-09-17 10:55:19 +1000 |
| commit | 12778fc14301cf24d79cd89b0129874c319d0a38 (patch) | |
| tree | a9a8bbdf466ac6394dc603eace7a069145460dc9 | |
| parent | 18c44db8cafe9bda4fcb51bfc05c1f1d7cefc44c (diff) | |
| download | blackbird-op-linux-12778fc14301cf24d79cd89b0129874c319d0a38.tar.gz blackbird-op-linux-12778fc14301cf24d79cd89b0129874c319d0a38.zip | |
drm/tilcdc: panel: Set return value explicitly
Instead of setting an initial value for the return code, set it explicitly
on each error path. This is just a cosmetic cleanup, as preparation for the
enable GPIO support.
Tested-by: Darren Etheridge <detheridge@ti.com>
Tested-by: Johannes Pointner <johannes.pointner@br-automation.com>
Signed-off-by: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
Signed-off-by: Dave Airlie <airlied@redhat.com>
| -rw-r--r-- | drivers/gpu/drm/tilcdc/tilcdc_panel.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/gpu/drm/tilcdc/tilcdc_panel.c b/drivers/gpu/drm/tilcdc/tilcdc_panel.c index 3dcf08e4dc91..f2a5b23782fa 100644 --- a/drivers/gpu/drm/tilcdc/tilcdc_panel.c +++ b/drivers/gpu/drm/tilcdc/tilcdc_panel.c @@ -346,7 +346,7 @@ static int panel_probe(struct platform_device *pdev) struct panel_module *panel_mod; struct tilcdc_module *mod; struct pinctrl *pinctrl; - int ret = -EINVAL; + int ret; /* bail out early if no DT data: */ if (!node) { @@ -381,12 +381,14 @@ static int panel_probe(struct platform_device *pdev) panel_mod->timings = of_get_display_timings(node); if (!panel_mod->timings) { dev_err(&pdev->dev, "could not get panel timings\n"); + ret = -EINVAL; goto fail_free; } panel_mod->info = of_get_panel_info(node); if (!panel_mod->info) { dev_err(&pdev->dev, "could not get panel info\n"); + ret = -EINVAL; goto fail_timings; } |
