summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJean Delvare <khali@linux-fr.org>2006-09-03 22:25:04 +0200
committerGreg Kroah-Hartman <gregkh@suse.de>2006-09-26 15:38:52 -0700
commit114fd18397eb0eacf51ac784f7d5c929b8499715 (patch)
tree902287737d800a5bcfa382419e48f98f7ed502fe
parent7eff82c8b1511017ae605f0c99ac275a7e21b867 (diff)
downloadblackbird-op-linux-114fd18397eb0eacf51ac784f7d5c929b8499715.tar.gz
blackbird-op-linux-114fd18397eb0eacf51ac784f7d5c929b8499715.zip
i2c: Warn on i2c client creation failure
i2c: Warn on i2c client creation failure Warn when an i2c client creation fails. If we don't, the user will never know something wrong happened, as i2c client creation is typically called through an attach_adapter callback, those return value we currently ignore for technical reasons. Signed-off-by: Jean Delvare <khali@linux-fr.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
-rw-r--r--drivers/i2c/i2c-core.c9
1 files changed, 7 insertions, 2 deletions
diff --git a/drivers/i2c/i2c-core.c b/drivers/i2c/i2c-core.c
index 88dd803174a1..01233f0f7771 100644
--- a/drivers/i2c/i2c-core.c
+++ b/drivers/i2c/i2c-core.c
@@ -707,11 +707,16 @@ static int i2c_probe_address(struct i2c_adapter *adapter, int addr, int kind,
/* Finally call the custom detection function */
err = found_proc(adapter, addr, kind);
-
/* -ENODEV can be returned if there is a chip at the given address
but it isn't supported by this chip driver. We catch it here as
this isn't an error. */
- return (err == -ENODEV) ? 0 : err;
+ if (err == -ENODEV)
+ err = 0;
+
+ if (err)
+ dev_warn(&adapter->dev, "Client creation failed at 0x%x (%d)\n",
+ addr, err);
+ return err;
}
int i2c_probe(struct i2c_adapter *adapter,
OpenPOWER on IntegriCloud