summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDave Chinner <dchinner@redhat.com>2014-04-17 08:15:27 +1000
committerDave Chinner <david@fromorbit.com>2014-04-17 08:15:27 +1000
commit07d5035a289f8bebe0ea86c293b2d5412478c481 (patch)
tree86af0bf1ad0fe31ab0c8f87b0bb66e45a6099962
parent9c23eccc1e746f64b18fab070a37189b4422e44a (diff)
downloadblackbird-op-linux-07d5035a289f8bebe0ea86c293b2d5412478c481.tar.gz
blackbird-op-linux-07d5035a289f8bebe0ea86c293b2d5412478c481.zip
xfs: wrong error sign conversion during failed DIO writes
We negate the error value being returned from a generic function incorrectly. The code path that it is running in returned negative errors, so there is no need to negate it to get the correct error signs here. This was uncovered by generic/019. Signed-off-by: Dave Chinner <dchinner@redhat.com> Reviewed-by: Christoph Hellwig <hch@lst.de> Signed-off-by: Dave Chinner <david@fromorbit.com>
-rw-r--r--fs/xfs/xfs_file.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/xfs/xfs_file.c b/fs/xfs/xfs_file.c
index 79e96ce98733..82afdcb33183 100644
--- a/fs/xfs/xfs_file.c
+++ b/fs/xfs/xfs_file.c
@@ -679,7 +679,7 @@ xfs_file_dio_aio_write(
goto out;
if (mapping->nrpages) {
- ret = -filemap_write_and_wait_range(VFS_I(ip)->i_mapping,
+ ret = filemap_write_and_wait_range(VFS_I(ip)->i_mapping,
pos, -1);
if (ret)
goto out;
OpenPOWER on IntegriCloud