diff options
| author | Mateusz Kulikowski <mateusz.kulikowski@gmail.com> | 2016-03-31 23:12:21 +0200 |
|---|---|---|
| committer | Tom Rini <trini@konsulko.com> | 2016-04-01 17:18:09 -0400 |
| commit | d3d844f84acf3d079959894709607188620989c5 (patch) | |
| tree | 1a39c7ec88991556428c06a6d6883d410bf45c97 /include/usb | |
| parent | 2cbe57cf26769cff6f8e79c0c9afe6773edbf16b (diff) | |
| download | blackbird-obmc-uboot-d3d844f84acf3d079959894709607188620989c5.tar.gz blackbird-obmc-uboot-d3d844f84acf3d079959894709607188620989c5.zip | |
usb: ulpi: Fix compile warning in read/write on 64-bit machines.
ulpi_read and ulpi_write are used to read/write registers via ULPI bus.
Code generates compilation warnings on 64-bit machines where pointer
is cast to u32.
This patch drops all but last 8 bits of register address.
It is possible, because addresses on ULPI bus are 6- or 8-bit.
It is not possible (according to ULPI 1.1 spec) to have more
than 8-bit addressing.
This patch should not cause regressions as all calls to
ulpi_read/write use either structure pointer (@ address 0) or integer
offsets cast to pointer - addresses requested are way below 8-bit range.
Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
Acked-by: Marek Vasut <marex@denx.de>
Diffstat (limited to 'include/usb')
| -rw-r--r-- | include/usb/ulpi.h | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/include/usb/ulpi.h b/include/usb/ulpi.h index dfea395806..747fb0a9fd 100644 --- a/include/usb/ulpi.h +++ b/include/usb/ulpi.h @@ -123,6 +123,7 @@ int ulpi_reset(struct ulpi_viewport *ulpi_vp); /* * Write to the ULPI PHY register via the viewport. * @reg - the ULPI register (one of the fields in struct ulpi_regs). + * Due to ULPI design, only 8 lsb of address are used. * @value - the value - only 8 lower bits are used, others ignored. * * returns 0 on success, ULPI_ERROR on failure. @@ -132,6 +133,7 @@ int ulpi_write(struct ulpi_viewport *ulpi_vp, u8 *reg, u32 value); /* * Read the ULPI PHY register content via the viewport. * @reg - the ULPI register (one of the fields in struct ulpi_regs). + * Due to ULPI design, only 8 lsb of address are used. * * returns register content on success, ULPI_ERROR on failure. */ |
