summaryrefslogtreecommitdiffstats
path: root/include/micrel.h
diff options
context:
space:
mode:
authorBhupesh Sharma <bhupesh.sharma@freescale.com>2013-09-01 04:40:52 +0530
committerJoe Hershberger <joe.hershberger@ni.com>2013-11-22 16:50:51 -0600
commit42205047674d7fc9e0aa747273fbc7dcfbac3183 (patch)
treeeaaed238d242cfa57d3945af44bcb24edc5b0863 /include/micrel.h
parente97a78cfed113dfbf9a0db712624bca69065c3a1 (diff)
downloadblackbird-obmc-uboot-42205047674d7fc9e0aa747273fbc7dcfbac3183.tar.gz
blackbird-obmc-uboot-42205047674d7fc9e0aa747273fbc7dcfbac3183.zip
net/phy: realtek: Fix the PHY ID mask to ensure the correct Realtek PHY is detected
The 'get_phy_driver' code in 'drivers/net/phy/phy.c' uses the following method to determine which driver is to be loaded for a particular PHY module: list_for_each(entry, &phy_drivers) { drv = list_entry(entry, struct phy_driver, list); if ((drv->uid & drv->mask) == (phy_id & drv->mask)) return drv; } This means that a drv->mask of 0xfffff0 will return incorrect phy driver for the logic above, even if the drv->uid is anything other than something ending with a 0x0. For e.g. if the RTL8211E drv->uid is 0x1cc915 and drv->mask is 0xffffff and the RTL8211B drv->uid is 0x1cc910 and drv->mask is 0xffffff0, then the phy driver selected will always be RTL8211B even though the underlying phy connected on the board is a 8211E module. This patch fixes this issue. Signed-off-by: Bhupesh Sharma <bhupesh.sharma@freescale.com>
Diffstat (limited to 'include/micrel.h')
0 files changed, 0 insertions, 0 deletions
OpenPOWER on IntegriCloud