diff options
| author | Vadim Bendebury <vbendeb@chromium.org> | 2014-02-27 13:26:04 -0700 |
|---|---|---|
| committer | Simon Glass <sjg@chromium.org> | 2014-03-17 20:05:46 -0600 |
| commit | 4ff9b461a8c50245a611b15a4fa67784cc452a3d (patch) | |
| tree | 528883c75feb7de77c138691f1f0df20b4306fce /drivers/misc/cros_ec.c | |
| parent | d7f25f35f448b15f815d355abd9ba39836fd9e32 (diff) | |
| download | blackbird-obmc-uboot-4ff9b461a8c50245a611b15a4fa67784cc452a3d.tar.gz blackbird-obmc-uboot-4ff9b461a8c50245a611b15a4fa67784cc452a3d.zip | |
cros_ec: Drop old EC version support from EC driver
There is no need to support old style EC moving forward. Ultimately we
should get rid of the check_version() API. For now just return error
in case the EC does not seem to support the new API.
Reviewed-by: Vadim Bendebury <vbendeb@google.com>
Tested-by: Vadim Bendebury <vbendeb@google.com>
Signed-off-by: Vadim Bendebury <vbendeb@chromium.org>
Signed-off-by: Simon Glass <sjg@chromium.org>
Diffstat (limited to 'drivers/misc/cros_ec.c')
| -rw-r--r-- | drivers/misc/cros_ec.c | 15 |
1 files changed, 3 insertions, 12 deletions
diff --git a/drivers/misc/cros_ec.c b/drivers/misc/cros_ec.c index 1998653754..f95bfe7390 100644 --- a/drivers/misc/cros_ec.c +++ b/drivers/misc/cros_ec.c @@ -132,10 +132,6 @@ static int ec_command_inptr(struct cros_ec_dev *dev, uint8_t cmd, uint8_t *din; int len; - if (cmd_version != 0 && !dev->cmd_version_is_supported) { - debug("%s: Command version >0 unsupported\n", __func__); - return -1; - } len = send_command(dev, cmd, cmd_version, dout, dout_len, &din, din_len); @@ -510,14 +506,9 @@ static int cros_ec_check_version(struct cros_ec_dev *dev) /* It appears to understand new version commands */ dev->cmd_version_is_supported = 1; } else { - dev->cmd_version_is_supported = 0; - if (ec_command_inptr(dev, EC_CMD_HELLO, 0, &req, - sizeof(req), (uint8_t **)&resp, - sizeof(*resp)) < 0) { - debug("%s: Failed both old and new command style\n", - __func__); - return -1; - } + printf("%s: ERROR: old EC interface not supported\n", + __func__); + return -1; } return 0; |
