diff options
| author | Anton Staaf <robotboy@chromium.org> | 2011-09-02 13:45:28 +0000 |
|---|---|---|
| committer | Wolfgang Denk <wd@denx.de> | 2011-09-07 23:39:36 +0200 |
| commit | 155cfb5ef18731a6d761edd2169699c67f0e1306 (patch) | |
| tree | cabc780527139333e622b50ef0903efc672354fb /common/cmd_sf.c | |
| parent | 49ea2e342b6b9c35623915125e4e0af734cfa594 (diff) | |
| download | blackbird-obmc-uboot-155cfb5ef18731a6d761edd2169699c67f0e1306.tar.gz blackbird-obmc-uboot-155cfb5ef18731a6d761edd2169699c67f0e1306.zip | |
common: fix behavior of ROUND macro when input is already rounded
Currently when you call ROUND with a value that is already a
multiple of the second parameter it will return a value that is
one multiple larger, instead of returning the value passed in.
There are only two types of usage of ROUND currently, one in
various config files to round CONFIG_SYS_MALLOC_LEN to a multiple
of 4096 bytes. The other in cmd_sf.c where the incorrect behavior
of ROUND is worked around be subtracting one from the length argument
before passing it to ROUND.
This patch fixes ROUND and removes the workaround from cmd_sf. It
also results in all of the malloc pools that use ROUND to compute
their size shrinking by 4KB.
Cc: Lukasz Majewski <l.majewski@samsung.com>
Cc: Mike Frysinger <vapier@gentoo.org>
Diffstat (limited to 'common/cmd_sf.c')
| -rw-r--r-- | common/cmd_sf.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/common/cmd_sf.c b/common/cmd_sf.c index 11a491df76..27d6e39a18 100644 --- a/common/cmd_sf.c +++ b/common/cmd_sf.c @@ -53,7 +53,7 @@ static int sf_parse_len_arg(char *arg, ulong *len) return -1; if (round_up_len && flash->sector_size > 0) - *len = ROUND(len_arg - 1, flash->sector_size); + *len = ROUND(len_arg, flash->sector_size); else *len = len_arg; |
