path: root/board/psyent/pci5441
diff options
authorTrent Piepho <>2009-02-18 15:22:05 -0800
committerWolfgang Denk <>2009-03-20 22:39:12 +0100
commitf62fb99941c625605aa16a0097b396a5c16d2c88 (patch)
treea0269ee7e9fa0efacf18d9b6b2a44000c731aa0f /board/psyent/pci5441
parent566b652c7cdb0e5e0529bb3d1eaffbd2bf45a032 (diff)
Fix all linker script to handle all rodata sections
A recent gcc added a new unaligned rodata section called '.rodata.str1.1', which needs to be added the the linker script. Instead of just adding this one section, we use a wildcard ".rodata*" to get all rodata linker section gcc has now and might add in the future. However, '*(.rodata*)' by itself will result in sub-optimal section ordering. The sections will be sorted by object file, which causes extra padding between the unaligned rodata.str.1.1 of one object file and the aligned rodata of the next object file. This is easy to fix by using the SORT_BY_ALIGNMENT command. This patch has not be tested one most of the boards modified. Some boards have a linker script that looks something like this: *(.text) . = ALIGN(16); *(.rodata) *(.rodata.str1.4) *(.eh_frame) I change this to: *(.text) . = ALIGN(16); *(.eh_frame) *(SORT_BY_ALIGNMENT(SORT_BY_NAME(.rodata*))) This means the start of rodata will no longer be 16 bytes aligned. However, the boundary between text and rodata/eh_frame is still aligned to 16 bytes, which is what I think the real purpose of the ALIGN call is. Signed-off-by: Trent Piepho <>
Diffstat (limited to 'board/psyent/pci5441')
1 files changed, 1 insertions, 2 deletions
diff --git a/board/psyent/pci5441/ b/board/psyent/pci5441/
index d3b7c31ae9..b2d88a5586 100644
--- a/board/psyent/pci5441/
+++ b/board/psyent/pci5441/
@@ -34,8 +34,7 @@ SECTIONS
- *(.rodata)
- *(.rodata.*)
. = ALIGN (4);
OpenPOWER on IntegriCloud