diff options
authorJayachandran Chandrasekharan Nair <>2012-07-10 11:48:54 +0530
committerJoe Hershberger <>2012-07-11 13:14:16 -0500
commitbc46dfac2f21756642e549b05689e03db538639f (patch)
parent211e47549b668c7cdd8658c0413a272f0d0495d4 (diff)
net: tftp: fix type of block arg to store_block
The block argument for store_block can be -1 when the tftp sequence number rolls over (i.e TftpBlock == 0), so the first argument to store_block has to be of type 'int' instead of 'unsigned'. In our environment (gcc 4.4.5 mips toolchain), this causes incorrect 'offset' to be generated for storing the block, and the tftp block with number 0 will be written elsewhere, resulting in a bad block in the downloaded file and a memory corruption. Signed-off-by: Jayachandran Chandrasekharan Nair <>
1 files changed, 1 insertions, 1 deletions
diff --git a/net/tftp.c b/net/tftp.c
index b2e08b4bfb..59a8ebb3cf 100644
--- a/net/tftp.c
+++ b/net/tftp.c
@@ -156,7 +156,7 @@ mcast_cleanup(void)
#endif /* CONFIG_MCAST_TFTP */
static inline void
-store_block(unsigned block, uchar *src, unsigned len)
+store_block(int block, uchar *src, unsigned len)
ulong offset = block * TftpBlkSize + TftpBlockWrapOffset;
ulong newsize = offset + len;
OpenPOWER on IntegriCloud