diff options
| author | Steven Rostedt <srostedt@redhat.com> | 2011-06-01 23:22:30 -0400 |
|---|---|---|
| committer | Steven Rostedt <rostedt@goodmis.org> | 2011-06-02 11:57:41 -0400 |
| commit | 4c8cc55b3c0ebe989e727017933945b68b4327cd (patch) | |
| tree | 725aa612c6d01c912e724c3dc0e1eb8f4e1b2712 /tools | |
| parent | 55922c9d1b84b89cb946c777fddccb3247e7df2c (diff) | |
| download | blackbird-obmc-linux-4c8cc55b3c0ebe989e727017933945b68b4327cd.tar.gz blackbird-obmc-linux-4c8cc55b3c0ebe989e727017933945b68b4327cd.zip | |
ktest: Fix off-by-one in config bisect result
Because in perl the array size returned by $#arr, is the last
index and not the actually size of the array, we end the config
bisect early, thinking there is only one config left when there
are in fact two. Thus the result has a 50% chance of picking
the correct config that caused the problem.
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
Diffstat (limited to 'tools')
| -rwxr-xr-x | tools/testing/ktest/ktest.pl | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/tools/testing/ktest/ktest.pl b/tools/testing/ktest/ktest.pl index 1fd29b2daa92..8dc8c3cf3acf 100755 --- a/tools/testing/ktest/ktest.pl +++ b/tools/testing/ktest/ktest.pl @@ -1638,7 +1638,7 @@ sub run_config_bisect { if (!$found) { # try the other half doprint "Top half produced no set configs, trying bottom half\n"; - @tophalf = @start_list[$half .. $#start_list]; + @tophalf = @start_list[$half + 1 .. $#start_list]; create_config @tophalf; read_current_config \%current_config; foreach my $config (@tophalf) { @@ -1690,7 +1690,7 @@ sub run_config_bisect { # remove half the configs we are looking at and see if # they are good. $half = int($#start_list / 2); - } while ($half > 0); + } while ($#start_list > 0); # we found a single config, try it again unless we are running manually |
