summaryrefslogtreecommitdiffstats
path: root/tools/testing
diff options
context:
space:
mode:
authorTycho Andersen <tycho@tycho.ws>2019-01-18 17:12:15 -0700
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2019-04-05 22:34:38 +0200
commit34968a446c4ee2163c129c27154fd88940c2c3ca (patch)
tree77a419cd7d1096c4178fbd6168a8f04857c38d5d /tools/testing
parent7981a5b4df776ca9be9747266784ebfc9fb7ad8a (diff)
downloadblackbird-obmc-linux-34968a446c4ee2163c129c27154fd88940c2c3ca.tar.gz
blackbird-obmc-linux-34968a446c4ee2163c129c27154fd88940c2c3ca.zip
selftests: skip seccomp get_metadata test if not real root
[ Upstream commit 3aa415dd2128e478ea3225b59308766de0e94d6b ] The get_metadata() test requires real root, so let's skip it if we're not real root. Note that I used XFAIL here because that's what the test does later if CONFIG_CHEKCKPOINT_RESTORE happens to not be enabled. After looking at the code, there doesn't seem to be a nice way to skip tests defined as TEST(), since there's no return code (I tried exit(KSFT_SKIP), but that didn't work either...). So let's do it this way to be consistent, and easier to fix when someone comes along and fixes it. Signed-off-by: Tycho Andersen <tycho@tycho.ws> Acked-by: Kees Cook <keescook@chromium.org> Signed-off-by: Shuah Khan <shuah@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'tools/testing')
-rw-r--r--tools/testing/selftests/seccomp/seccomp_bpf.c6
1 files changed, 6 insertions, 0 deletions
diff --git a/tools/testing/selftests/seccomp/seccomp_bpf.c b/tools/testing/selftests/seccomp/seccomp_bpf.c
index 7e632b465ab4..6d7a81306f8a 100644
--- a/tools/testing/selftests/seccomp/seccomp_bpf.c
+++ b/tools/testing/selftests/seccomp/seccomp_bpf.c
@@ -2971,6 +2971,12 @@ TEST(get_metadata)
struct seccomp_metadata md;
long ret;
+ /* Only real root can get metadata. */
+ if (geteuid()) {
+ XFAIL(return, "get_metadata requires real root");
+ return;
+ }
+
ASSERT_EQ(0, pipe(pipefd));
pid = fork();
OpenPOWER on IntegriCloud