diff options
| author | Sven Eckelmann <sven@narfation.org> | 2016-07-15 17:39:19 +0200 |
|---|---|---|
| committer | Simon Wunderlich <sw@simonwunderlich.de> | 2016-08-09 07:54:45 +0200 |
| commit | 2e774ac2f7ad4a7fb4289b7aacd9709bf3e2f991 (patch) | |
| tree | 4c072e314cc96800b63830994bed67a2b2900065 /net/batman-adv/originator.c | |
| parent | 23f554855911f788474b52ff3b7af656b5b61239 (diff) | |
| download | blackbird-obmc-linux-2e774ac2f7ad4a7fb4289b7aacd9709bf3e2f991.tar.gz blackbird-obmc-linux-2e774ac2f7ad4a7fb4289b7aacd9709bf3e2f991.zip | |
batman-adv: Place kref_get for neigh_ifinfo near use
It is hard to understand why the refcnt is increased when it isn't done
near the actual place the new reference is used. So using kref_get right
before the place which requires the reference and in the same function
helps to avoid accidental problems caused by incorrect reference counting.
Signed-off-by: Sven Eckelmann <sven@narfation.org>
Signed-off-by: Marek Lindner <mareklindner@neomailbox.ch>
Signed-off-by: Simon Wunderlich <sw@simonwunderlich.de>
Diffstat (limited to 'net/batman-adv/originator.c')
| -rw-r--r-- | net/batman-adv/originator.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/batman-adv/originator.c b/net/batman-adv/originator.c index 88289645f3c9..5e99a6e296e6 100644 --- a/net/batman-adv/originator.c +++ b/net/batman-adv/originator.c @@ -460,9 +460,9 @@ batadv_neigh_ifinfo_new(struct batadv_neigh_node *neigh, INIT_HLIST_NODE(&neigh_ifinfo->list); kref_init(&neigh_ifinfo->refcount); - kref_get(&neigh_ifinfo->refcount); neigh_ifinfo->if_outgoing = if_outgoing; + kref_get(&neigh_ifinfo->refcount); hlist_add_head_rcu(&neigh_ifinfo->list, &neigh->ifinfo_list); out: |
