diff options
| author | Arnd Bergmann <arnd@arndb.de> | 2016-01-13 21:51:29 +0100 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2016-01-15 18:13:53 +0000 |
| commit | ebea7c0545d4d5e554b84c3ee8072f13c3fdd2ba (patch) | |
| tree | 48367a617efced8adee1e856b330103a00a02a70 /drivers/spi/spi-loopback-test.c | |
| parent | cabeea980879c2c701b0bd03f145c9f7dae17a63 (diff) | |
| download | blackbird-obmc-linux-ebea7c0545d4d5e554b84c3ee8072f13c3fdd2ba.tar.gz blackbird-obmc-linux-ebea7c0545d4d5e554b84c3ee8072f13c3fdd2ba.zip | |
spi: fix counting in spi-loopback-test code
These variables are always used uninitialized:
drivers/spi/spi-loopback-test.c: In function 'spi_test_run_iter':
drivers/spi/spi-loopback-test.c:768:17: warning: 'rx_count' may be used uninitialized in this function [-Wmaybe-uninitialized]
drivers/spi/spi-loopback-test.c:762:17: warning: 'tx_count' may be used uninitialized in this function [-Wmaybe-uninitialized]
Adding an explicit initialization seems to be the only
workable solution here, to make the code behave correctly
and build without warning.
Fixes: 84e0c4e5e2c4 ("spi: add loopback test driver to allow for spi_master regression tests")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'drivers/spi/spi-loopback-test.c')
| -rw-r--r-- | drivers/spi/spi-loopback-test.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/spi/spi-loopback-test.c b/drivers/spi/spi-loopback-test.c index 894616f687b0..cf4bb36bee25 100644 --- a/drivers/spi/spi-loopback-test.c +++ b/drivers/spi/spi-loopback-test.c @@ -761,6 +761,7 @@ static int spi_test_run_iter(struct spi_device *spi, test.iterate_transfer_mask = 1; /* count number of transfers with tx/rx_buf != NULL */ + rx_count = tx_count = 0; for (i = 0; i < test.transfer_count; i++) { if (test.transfers[i].tx_buf) tx_count++; |
