summaryrefslogtreecommitdiffstats
path: root/drivers/scsi
diff options
context:
space:
mode:
authorDan Carpenter <dan.carpenter@oracle.com>2012-05-17 10:13:40 +0300
committerJames Bottomley <JBottomley@Parallels.com>2012-05-22 11:52:20 +0100
commit841f97bffc11daaef9eb28d201be25b1509db97d (patch)
tree45b9a5843858874093b0cd6ddc2a8e602d265ece /drivers/scsi
parent83ff74e33849cd5592efa1ea583175600b6a485e (diff)
downloadblackbird-obmc-linux-841f97bffc11daaef9eb28d201be25b1509db97d.tar.gz
blackbird-obmc-linux-841f97bffc11daaef9eb28d201be25b1509db97d.zip
[SCSI] qla2xxx: don't free pool that wasn't allocated
In the original code, if dma_pool_alloc() fails then we call dma_pool_free(). It causes an error, possibly a NULL dereference. Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Acked-by: Chad Dupuis <chad.dupuis@qlogic.com> Signed-off-by: James Bottomley <JBottomley@Parallels.com>
Diffstat (limited to 'drivers/scsi')
-rw-r--r--drivers/scsi/qla2xxx/qla_iocb.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/scsi/qla2xxx/qla_iocb.c b/drivers/scsi/qla2xxx/qla_iocb.c
index 73cc96da9421..70dbf53d9e0f 100644
--- a/drivers/scsi/qla2xxx/qla_iocb.c
+++ b/drivers/scsi/qla2xxx/qla_iocb.c
@@ -2382,7 +2382,7 @@ sufficient_dsds:
if (!ctx->fcp_cmnd) {
ql_log(ql_log_fatal, vha, 0x3011,
"Failed to allocate fcp_cmnd for cmd=%p.\n", cmd);
- goto queuing_error_fcp_cmnd;
+ goto queuing_error;
}
/* Initialize the DSD list and dma handle */
OpenPOWER on IntegriCloud