summaryrefslogtreecommitdiffstats
path: root/drivers/scsi
diff options
context:
space:
mode:
authorJoe Malicki <jmalicki@metacarta.com>2008-08-14 17:14:48 -0400
committerJames Bottomley <James.Bottomley@HansenPartnership.com>2008-08-16 10:32:24 -0500
commit66dca9b8c50b5e59d3bea8b21cee5c6dae6c9c46 (patch)
tree1bc8984becac06db8167f136f4d5c8ca8e6abdb4 /drivers/scsi
parentbcd2361d7eda10f85a103cbe70f7eebaeef03072 (diff)
downloadblackbird-obmc-linux-66dca9b8c50b5e59d3bea8b21cee5c6dae6c9c46.tar.gz
blackbird-obmc-linux-66dca9b8c50b5e59d3bea8b21cee5c6dae6c9c46.zip
[SCSI] megaraid_sas: remove sysfs dbg_lvl world writeable permissions
/sys/bus/pci/drivers/megaraid_sas/dbg_lvl defaults to being world-writable, which seems bad (letting any user affect kernel driver behavior and logging level). This turns off group and user write permissions, so that on typical production systems only root can write to it. [jejb: fix up rejections] Signed-off-by: Joseph Malicki <jmalicki@metacarta.com> Acked-by: "Yang, Bo" <Bo.Yang@lsi.com> Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
Diffstat (limited to 'drivers/scsi')
-rw-r--r--drivers/scsi/megaraid/megaraid_sas.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/scsi/megaraid/megaraid_sas.c b/drivers/scsi/megaraid/megaraid_sas.c
index 870dc1c6302f..97b763378e7d 100644
--- a/drivers/scsi/megaraid/megaraid_sas.c
+++ b/drivers/scsi/megaraid/megaraid_sas.c
@@ -3405,7 +3405,7 @@ megasas_sysfs_set_dbg_lvl(struct device_driver *dd, const char *buf, size_t coun
return retval;
}
-static DRIVER_ATTR(dbg_lvl, S_IRUGO|S_IWUGO, megasas_sysfs_show_dbg_lvl,
+static DRIVER_ATTR(dbg_lvl, S_IRUGO|S_IWUSR, megasas_sysfs_show_dbg_lvl,
megasas_sysfs_set_dbg_lvl);
static ssize_t
OpenPOWER on IntegriCloud