diff options
| author | Roland Dreier <roland@purestorage.com> | 2012-06-11 18:31:31 -0700 |
|---|---|---|
| committer | Nicholas Bellinger <nab@linux-iscsi.org> | 2012-06-12 20:15:49 -0700 |
| commit | d4f75b567bb63b51e5ecd42af1e82d5aed5100dd (patch) | |
| tree | 258490017b2aa269022cac58ff0c80ab329a2e3a /drivers/scsi/qla2xxx/qla_def.h | |
| parent | 9389c3c943da7e5f903eebf79d596601537afe01 (diff) | |
| download | blackbird-obmc-linux-d4f75b567bb63b51e5ecd42af1e82d5aed5100dd.tar.gz blackbird-obmc-linux-d4f75b567bb63b51e5ecd42af1e82d5aed5100dd.zip | |
tcm_qla2xxx: Handle malformed wwn strings properly
If we make a variable an unsigned int and then expect it to be < 0 on
a bad character, we're going to have a bad time. Fix the tcm_qla2xxx
code to actually notice if hex_to_bin() returns a negative variable.
This was detected by the compiler warning:
scsi/qla2xxx/tcm_qla2xxx.c: In function ‘tcm_qla2xxx_npiv_extract_wwn’:
scsi/qla2xxx/tcm_qla2xxx.c:148:3: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]
Signed-off-by: Roland Dreier <roland@purestorage.com>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
Diffstat (limited to 'drivers/scsi/qla2xxx/qla_def.h')
0 files changed, 0 insertions, 0 deletions
