diff options
author | Michael S. Tsirkin <mst@redhat.com> | 2017-12-05 21:29:37 +0200 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2017-12-11 10:52:23 -0500 |
commit | a8ceb5dbfde1092b466936bca0ff3be127ecf38e (patch) | |
tree | 768483ddf27f70faa09ffe0f4a0c90a35119f249 /drivers/reset/reset-lpc18xx.c | |
parent | f0f1d0166b17e1fadaa1dfa99721a9abb97e65eb (diff) | |
download | blackbird-obmc-linux-a8ceb5dbfde1092b466936bca0ff3be127ecf38e.tar.gz blackbird-obmc-linux-a8ceb5dbfde1092b466936bca0ff3be127ecf38e.zip |
ptr_ring: add barriers
Users of ptr_ring expect that it's safe to give the
data structure a pointer and have it be available
to consumers, but that actually requires an smb_wmb
or a stronger barrier.
In absence of such barriers and on architectures that reorder writes,
consumer might read an un=initialized value from an skb pointer stored
in the skb array. This was observed causing crashes.
To fix, add memory barriers. The barrier we use is a wmb, the
assumption being that producers do not need to read the value so we do
not need to order these reads.
Reported-by: George Cherian <george.cherian@cavium.com>
Suggested-by: Jason Wang <jasowang@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Acked-by: Jason Wang <jasowang@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/reset/reset-lpc18xx.c')
0 files changed, 0 insertions, 0 deletions