summaryrefslogtreecommitdiffstats
path: root/drivers/net
diff options
context:
space:
mode:
authorEric Dumazet <edumazet@google.com>2019-03-16 13:09:53 -0700
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2019-04-03 06:27:26 +0200
commitbb06073a9cad930f5c8bb5f433dcd478c26608dd (patch)
tree0f9b76a8a7ef8cd7e48b8bcabfa1e746a36e3935 /drivers/net
parentd01bf3762e290a58d7f1941a42b13322f7803564 (diff)
downloadblackbird-obmc-linux-bb06073a9cad930f5c8bb5f433dcd478c26608dd.tar.gz
blackbird-obmc-linux-bb06073a9cad930f5c8bb5f433dcd478c26608dd.zip
tun: add a missing rcu_read_unlock() in error path
commit 9180bb4f046064dfa4541488102703b402bb04e1 upstream. In my latest patch I missed one rcu_read_unlock(), in case device is down. Fixes: 4477138fa0ae ("tun: properly test for IFF_UP") Signed-off-by: Eric Dumazet <edumazet@google.com> Reported-by: syzbot <syzkaller@googlegroups.com> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/net')
-rw-r--r--drivers/net/tun.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/net/tun.c b/drivers/net/tun.c
index f4126ce58878..448d5439ff6a 100644
--- a/drivers/net/tun.c
+++ b/drivers/net/tun.c
@@ -1960,6 +1960,7 @@ drop:
rcu_read_lock();
if (unlikely(!(tun->dev->flags & IFF_UP))) {
err = -EIO;
+ rcu_read_unlock();
goto drop;
}
OpenPOWER on IntegriCloud