diff options
| author | Timur Tabi <timur@codeaurora.org> | 2017-10-11 14:52:26 -0500 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2017-10-11 16:01:56 -0700 |
| commit | 740d6f188fb71ae13e3e9f7208b6b3094517509d (patch) | |
| tree | 29553181be9be0d3a225ac4a5d7bbd63b6393637 /drivers/net/ethernet/qualcomm/emac/emac.c | |
| parent | df1ec1b9d0df57e96011f175418dc95b1af46821 (diff) | |
| download | blackbird-obmc-linux-740d6f188fb71ae13e3e9f7208b6b3094517509d.tar.gz blackbird-obmc-linux-740d6f188fb71ae13e3e9f7208b6b3094517509d.zip | |
net: qcom/emac: clean up some TX/RX error messages
Some of the error messages that are printed by the interrupt handlers
are poorly written. For example, many don't include a device prefix,
so there's no indication that they are EMAC errors.
Also use rate limiting for all messages that could be printed from
interrupt context.
Signed-off-by: Timur Tabi <timur@codeaurora.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/qualcomm/emac/emac.c')
| -rw-r--r-- | drivers/net/ethernet/qualcomm/emac/emac.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/drivers/net/ethernet/qualcomm/emac/emac.c b/drivers/net/ethernet/qualcomm/emac/emac.c index ee6f2d27502c..70c92b649b29 100644 --- a/drivers/net/ethernet/qualcomm/emac/emac.c +++ b/drivers/net/ethernet/qualcomm/emac/emac.c @@ -148,9 +148,8 @@ static irqreturn_t emac_isr(int _irq, void *data) goto exit; if (status & ISR_ERROR) { - netif_warn(adpt, intr, adpt->netdev, - "warning: error irq status 0x%lx\n", - status & ISR_ERROR); + net_err_ratelimited("%s: error interrupt 0x%lx\n", + adpt->netdev->name, status & ISR_ERROR); /* reset MAC */ schedule_work(&adpt->work_thread); } @@ -169,7 +168,8 @@ static irqreturn_t emac_isr(int _irq, void *data) emac_mac_tx_process(adpt, &adpt->tx_q); if (status & ISR_OVER) - net_warn_ratelimited("warning: TX/RX overflow\n"); + net_warn_ratelimited("%s: TX/RX overflow interrupt\n", + adpt->netdev->name); exit: /* enable the interrupt */ |
