diff options
| author | Fabio Estevam <fabio.estevam@freescale.com> | 2014-09-22 17:55:29 -0300 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2014-09-26 15:39:59 -0400 |
| commit | aebac744932439b5f869869f07f406a9cced465d (patch) | |
| tree | ee80643e5dd8e156ad23b492874f5409cd44f1e9 /drivers/net/ethernet/freescale/fec_main.c | |
| parent | 57219dc7bfc5cae48c8309974054733499a0dc63 (diff) | |
| download | blackbird-obmc-linux-aebac744932439b5f869869f07f406a9cced465d.tar.gz blackbird-obmc-linux-aebac744932439b5f869869f07f406a9cced465d.zip | |
fec: Remove fec_enet_select_queue()
Sparse complains about fec_enet_select_queue() not being static.
Feedback from David Miller [1] was to remove this function instead of making it
static:
"Please just delete this function.
It's overriding code which does exactly the same thing.
Actually, more precisely, this code is duplicating code in a way that
bypasses many core facilitites of the networking. For example, this
override means that socket based flow steering, XPS, etc. are all
not happening on these devices.
Without ->ndo_select_queue(), the flow dissector does __netdev_pick_tx
which is exactly what you want to happen."
[1] http://www.spinics.net/lists/netdev/msg297653.html
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/freescale/fec_main.c')
| -rw-r--r-- | drivers/net/ethernet/freescale/fec_main.c | 7 |
1 files changed, 0 insertions, 7 deletions
diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c index 3a4ec0ff1a8c..7379f4bb74b0 100644 --- a/drivers/net/ethernet/freescale/fec_main.c +++ b/drivers/net/ethernet/freescale/fec_main.c @@ -2851,17 +2851,10 @@ static int fec_set_features(struct net_device *netdev, return 0; } -u16 fec_enet_select_queue(struct net_device *ndev, struct sk_buff *skb, - void *accel_priv, select_queue_fallback_t fallback) -{ - return skb_tx_hash(ndev, skb); -} - static const struct net_device_ops fec_netdev_ops = { .ndo_open = fec_enet_open, .ndo_stop = fec_enet_close, .ndo_start_xmit = fec_enet_start_xmit, - .ndo_select_queue = fec_enet_select_queue, .ndo_set_rx_mode = set_multicast_list, .ndo_change_mtu = eth_change_mtu, .ndo_validate_addr = eth_validate_addr, |
