summaryrefslogtreecommitdiffstats
path: root/drivers/media/pci
diff options
context:
space:
mode:
authorColin Ian King <colin.king@canonical.com>2018-06-12 05:42:00 -0400
committerMauro Carvalho Chehab <mchehab+samsung@kernel.org>2018-06-28 07:54:03 -0400
commit7534122d60066a50859c422ced4636deb23760bf (patch)
tree2fadf5a40993fea317b2c7f31a002c78ae79de86 /drivers/media/pci
parent34dbb848d5e47f0a16abeb40885f93dd43045ff1 (diff)
downloadblackbird-obmc-linux-7534122d60066a50859c422ced4636deb23760bf.tar.gz
blackbird-obmc-linux-7534122d60066a50859c422ced4636deb23760bf.zip
media: cx18: remove redundant zero check on retval
The check for a zero retval is redundant as all paths that lead to this point have set retval to an error return value that is non-zero. Remove the redundant check. Detected by CoverityScan, CID#102589 ("Logically dead code") Signed-off-by: Colin Ian King <colin.king@canonical.com> Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com> Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
Diffstat (limited to 'drivers/media/pci')
-rw-r--r--drivers/media/pci/cx18/cx18-driver.c2
1 files changed, 0 insertions, 2 deletions
diff --git a/drivers/media/pci/cx18/cx18-driver.c b/drivers/media/pci/cx18/cx18-driver.c
index 8f314ca320c7..0c389a3fb4e5 100644
--- a/drivers/media/pci/cx18/cx18-driver.c
+++ b/drivers/media/pci/cx18/cx18-driver.c
@@ -1134,8 +1134,6 @@ free_mem:
free_workqueues:
destroy_workqueue(cx->in_work_queue);
err:
- if (retval == 0)
- retval = -ENODEV;
CX18_ERR("Error %d on initialization\n", retval);
v4l2_device_unregister(&cx->v4l2_dev);
OpenPOWER on IntegriCloud