diff options
| author | Vishwanathapura, Niranjana <niranjana.vishwanathapura@intel.com> | 2017-06-14 12:34:42 -0700 |
|---|---|---|
| committer | Doug Ledford <dledford@redhat.com> | 2017-06-29 12:43:52 -0400 |
| commit | a379d69f00f28063a7a1c3de235e2996c2c5a6f5 (patch) | |
| tree | a76985165abc913ff6e377c2445a3f853a697c90 /drivers/infiniband/ulp/opa_vnic/opa_vnic_internal.h | |
| parent | 0568c4640e2b12df063d1761fd4d53af24dc4018 (diff) | |
| download | blackbird-obmc-linux-a379d69f00f28063a7a1c3de235e2996c2c5a6f5.tar.gz blackbird-obmc-linux-a379d69f00f28063a7a1c3de235e2996c2c5a6f5.zip | |
IB/opa_vnic: Use spinlock instead of mutex for stats_lock
Stats can be read from atomic context, hence make stats_lock as
a spinlock.
Fix the following trace with debug kernel.
BUG: sleeping function called from invalid context at
kernel/locking/mutex.c:238
in_atomic(): 1, irqs_disabled(): 0, pid: 6487, name: sadc
Call Trace:
dump_stack+0x63/0x90
___might_sleep+0xda/0x130
__might_sleep+0x4a/0x90
mutex_lock+0x20/0x50
opa_vnic_get_stats64+0x56/0x140 [opa_vnic]
dev_get_stats+0x74/0x130
dev_seq_printf_stats+0x37/0x120
dev_seq_show+0x14/0x30
seq_read+0x26d/0x3d0
Reviewed-by: Mike Marciniszyn <mike.marciniszyn@intel.com>
Reviewed-by: Dennis Dalessandro <dennis.dalessandro@intel.com>
Signed-off-by: Niranjana Vishwanathapura <niranjana.vishwanathapura@intel.com>
Signed-off-by: Doug Ledford <dledford@redhat.com>
Diffstat (limited to 'drivers/infiniband/ulp/opa_vnic/opa_vnic_internal.h')
| -rw-r--r-- | drivers/infiniband/ulp/opa_vnic/opa_vnic_internal.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/infiniband/ulp/opa_vnic/opa_vnic_internal.h b/drivers/infiniband/ulp/opa_vnic/opa_vnic_internal.h index 6bba886bec1f..ca29e6d5aedc 100644 --- a/drivers/infiniband/ulp/opa_vnic/opa_vnic_internal.h +++ b/drivers/infiniband/ulp/opa_vnic/opa_vnic_internal.h @@ -214,7 +214,7 @@ struct opa_vnic_adapter { struct mutex mactbl_lock; /* Lock used to protect access to vnic counters */ - struct mutex stats_lock; + spinlock_t stats_lock; u8 flow_tbl[OPA_VNIC_FLOW_TBL_SIZE]; |
