summaryrefslogtreecommitdiffstats
path: root/drivers/firmware
diff options
context:
space:
mode:
authorArd Biesheuvel <ard.biesheuvel@linaro.org>2018-07-20 10:47:22 +0900
committerIngo Molnar <mingo@kernel.org>2018-07-22 14:13:43 +0200
commit093174f52553532b9eb0e63cbbb254f6990d46d5 (patch)
tree80f3749a353e0993b309112f59516f3f0e783492 /drivers/firmware
parent290084c2fa13e9aaa7f856ed1ab30760327dd9f8 (diff)
downloadblackbird-obmc-linux-093174f52553532b9eb0e63cbbb254f6990d46d5.tar.gz
blackbird-obmc-linux-093174f52553532b9eb0e63cbbb254f6990d46d5.zip
efi/x86: Add missing NULL initialization in UGA draw protocol discovery
The UGA draw protocol discovery routine looks for a EFI handle that has both the UGA draw protocol and the PCI I/O protocol installed. It checks for the latter by calling handle_protocol() and pass it a PCI I/O protocol pointer variable by reference, but fails to initialize it to NULL, which means the non-NULL check later on in the code could produce false positives, given that the return code of the handle_protocol() call is ignored entirely. So add the missing initialization. Tested-by: Hans de Goede <hdegoede@redhat.com> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Cc: Linus Torvalds <torvalds@linux-foundation.org> Cc: Lukas Wunner <lukas@wunner.de> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Thomas Gleixner <tglx@linutronix.de> Cc: linux-efi@vger.kernel.org Link: http://lkml.kernel.org/r/20180720014726.24031-6-ard.biesheuvel@linaro.org Signed-off-by: Ingo Molnar <mingo@kernel.org>
Diffstat (limited to 'drivers/firmware')
0 files changed, 0 insertions, 0 deletions
OpenPOWER on IntegriCloud