summaryrefslogtreecommitdiffstats
path: root/drivers/cpufreq/ppc-corenet-cpufreq.c
diff options
context:
space:
mode:
authorRafael J. Wysocki <rafael.j.wysocki@intel.com>2014-03-12 21:49:33 +0100
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>2014-03-13 00:37:16 +0100
commit2ed99e39cb9392312c100d9da591c20641c64d12 (patch)
tree488c4931187506f86ead99c64d3f2cf17d6fc764 /drivers/cpufreq/ppc-corenet-cpufreq.c
parentfa389e220254c69ffae0d403eac4146171062d08 (diff)
downloadblackbird-obmc-linux-2ed99e39cb9392312c100d9da591c20641c64d12.tar.gz
blackbird-obmc-linux-2ed99e39cb9392312c100d9da591c20641c64d12.zip
cpufreq: Skip current frequency initialization for ->setpolicy drivers
After commit da60ce9f2fac (cpufreq: call cpufreq_driver->get() after calling ->init()) __cpufreq_add_dev() sometimes fails for CPUs handled by intel_pstate, because that driver may return 0 from its ->get() callback if it has not run long enough to collect enough samples on the given CPU. That didn't happen before commit da60ce9f2fac which added policy->cur initialization to __cpufreq_add_dev() to help reduce code duplication in other cpufreq drivers. However, the code added by commit da60ce9f2fac need not be executed for cpufreq drivers having the ->setpolicy callback defined, because the subsequent invocation of cpufreq_set_policy() will use that callback to initialize the policy anyway and it doesn't need policy->cur to be initialized upfront. The analogous code in cpufreq_update_policy() is also unnecessary for cpufreq drivers having ->setpolicy set and may be skipped for them as well. Since intel_pstate provides ->setpolicy, skipping the upfront policy->cur initialization for cpufreq drivers with that callback set will cover intel_pstate and the problem it's been having after commit da60ce9f2fac will be addressed. Fixes: da60ce9f2fac (cpufreq: call cpufreq_driver->get() after calling ->init()) References: https://bugzilla.kernel.org/show_bug.cgi?id=71931 Reported-and-tested-by: Patrik Lundquist <patrik.lundquist@gmail.com> Acked-by: Dirk Brandewie <dirk.j.brandewie@intel.com> Cc: 3.13+ <stable@vger.kernel.org> # 3.13+ Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Diffstat (limited to 'drivers/cpufreq/ppc-corenet-cpufreq.c')
0 files changed, 0 insertions, 0 deletions
OpenPOWER on IntegriCloud