diff options
| author | Soren Brinkmann <soren.brinkmann@xilinx.com> | 2013-04-03 12:17:12 -0700 |
|---|---|---|
| committer | Mike Turquette <mturquette@linaro.org> | 2013-04-10 16:33:53 -0700 |
| commit | fb72a0590b770f7da6a02bde6b8a147a3d9f6168 (patch) | |
| tree | b842b02beb3a44b0d595f0b6020b8ed71c8f448e /drivers/clk/clk-si5351.h | |
| parent | 312f0f0b9a4e3e2cc8ad1bbc4577a6dff025cdf6 (diff) | |
| download | blackbird-obmc-linux-fb72a0590b770f7da6a02bde6b8a147a3d9f6168.tar.gz blackbird-obmc-linux-fb72a0590b770f7da6a02bde6b8a147a3d9f6168.zip | |
clk: Properly handle notifier return values
Notifiers may return NOTIFY_(OK|DONE|STOP|BAD). The CCF uses an
inconsistent mix of checking against NOTIFY_STOP or NOTIFY_BAD.
This inconsistency leaves errors undetected in some cases:
clk_set_parent() calls __clk_speculate_rates(), which stops when it
hits a NOTIFIER_BAD (STOP is ignored), and passes this value back to the
caller.
clk_set_parent() compares this return value against NOTIFY_STOP only,
ignoring NOTIFY_BAD returns.
Use NOTIFY_STOP_MASK to detect a negative notifier return value and
document all four return value options.
Signed-off-by: Soren Brinkmann <soren.brinkmann@xilinx.com>
Signed-off-by: Mike Turquette <mturquette@linaro.org>
Diffstat (limited to 'drivers/clk/clk-si5351.h')
0 files changed, 0 insertions, 0 deletions
