summaryrefslogtreecommitdiffstats
path: root/arch/mips
diff options
context:
space:
mode:
authorPaul Burton <paul.burton@imgtec.com>2015-09-22 10:26:39 -0700
committerRalf Baechle <ralf@linux-mips.org>2015-10-26 09:49:46 +0100
commitf88e632480baf223cad67ac553a6729535db6d74 (patch)
tree38c35a4b00b0d58730c3aa9f78fa158c2714228f /arch/mips
parent03b1b85d3d6c4f4153472afb7e015f1352e0c8f2 (diff)
downloadblackbird-obmc-linux-f88e632480baf223cad67ac553a6729535db6d74.tar.gz
blackbird-obmc-linux-f88e632480baf223cad67ac553a6729535db6d74.zip
MIPS: Avoid buffer overrun in mips_cm_error_report
Commit 3885c2b463f6 ("MIPS: CM: Add support for reporting CM cache errors") added cases for decoding errors reported by CM3, but leaves the buf variable which is printed as a string uninitialised for cause values other than 1, 2 or 3. Fix by ensuring the buf variable is initialised to an empty string in such cases. Signed-off-by: Paul Burton <paul.burton@imgtec.com> Cc: linux-mips@linux-mips.org Cc: Markos Chandras <markos.chandras@imgtec.com> Cc: linux-kernel@vger.kernel.org Patchwork: https://patchwork.linux-mips.org/patch/11187/ Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
Diffstat (limited to 'arch/mips')
-rw-r--r--arch/mips/kernel/mips-cm.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/arch/mips/kernel/mips-cm.c b/arch/mips/kernel/mips-cm.c
index 10524ce769ae..88a8e21a51dd 100644
--- a/arch/mips/kernel/mips-cm.c
+++ b/arch/mips/kernel/mips-cm.c
@@ -366,6 +366,8 @@ void mips_cm_error_report(void)
cm3_cmd_group[cmd_group_bits],
cm3_cca_bits, 1 << mcp_bits,
cm3_tr[cm3_tr_bits], sched_bit);
+ } else {
+ buf[0] = 0;
}
pr_err("CM_ERROR=%llx %s <%s>\n", cm_error,
OpenPOWER on IntegriCloud