diff options
| author | Sudeep Holla <Sudeep.Holla@arm.com> | 2018-01-18 10:43:39 +0000 |
|---|---|---|
| committer | Arnd Bergmann <arnd@arndb.de> | 2018-01-23 10:15:11 +0100 |
| commit | e2105ca8beb0c776a52ae8d18bc6b564745de2e4 (patch) | |
| tree | d00c06bed8be6ba9e112dca4f42395e1f5121a65 | |
| parent | 95140ed16db560ef86ab4ebe1a4e9b748d098669 (diff) | |
| download | blackbird-obmc-linux-e2105ca8beb0c776a52ae8d18bc6b564745de2e4.tar.gz blackbird-obmc-linux-e2105ca8beb0c776a52ae8d18bc6b564745de2e4.zip | |
of: platform: fix OF node refcount leak
We need to call of_node_put() for device nodes obtained with
of_find_node_by_path().
Fixes: 3aa0582fdb82 ("of: platform: populate /firmware/ node from of_platform_default_populate_init()")
Reported-by: Loys Ollivier <lollivier@baylibre.com>
Cc: Frank Rowand <frowand.list@gmail.com>
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
Acked-by: Rob Herring <robh@kernel.org>
Signed-off-by: Andy Gross <andy.gross@linaro.org>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
| -rw-r--r-- | drivers/of/platform.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/of/platform.c b/drivers/of/platform.c index 78cfb15c7890..faf7d87f8833 100644 --- a/drivers/of/platform.c +++ b/drivers/of/platform.c @@ -519,8 +519,10 @@ static int __init of_platform_default_populate_init(void) of_platform_device_create(node, NULL, NULL); node = of_find_node_by_path("/firmware"); - if (node) + if (node) { of_platform_populate(node, NULL, NULL, NULL); + of_node_put(node); + } /* Populate everything else. */ of_platform_default_populate(NULL, NULL, NULL); |
