summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorIdo Schimmel <idosch@mellanox.com>2018-01-07 12:45:02 +0200
committerDavid S. Miller <davem@davemloft.net>2018-01-07 21:29:39 -0500
commit2b2413610ef6fc9df9ad003b02fecc3a8057231e (patch)
treee4e88d806e5d969859a11baa5475687d0015c752
parent9fcb0714dc38250d3b56d28c0b5a0bde0d2a59f2 (diff)
downloadblackbird-obmc-linux-2b2413610ef6fc9df9ad003b02fecc3a8057231e.tar.gz
blackbird-obmc-linux-2b2413610ef6fc9df9ad003b02fecc3a8057231e.zip
ipv6: Mark dead nexthops with appropriate flags
When a netdev is put administratively down or unregistered all the nexthops using it as their nexthop device should be marked with the 'dead' and 'linkdown' flags. Currently, when a route is dumped its nexthop device is tested and the flags are set accordingly. A similar check is performed during route lookup. Instead, we can simply mark the nexthops based on netdev events and avoid checking the netdev's state during route dump and lookup. Signed-off-by: Ido Schimmel <idosch@mellanox.com> Acked-by: David Ahern <dsahern@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r--net/ipv6/route.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/net/ipv6/route.c b/net/ipv6/route.c
index c557362daa23..f5eda0aeab55 100644
--- a/net/ipv6/route.c
+++ b/net/ipv6/route.c
@@ -3473,8 +3473,10 @@ static int fib6_ifdown(struct rt6_info *rt, void *arg)
if (rt->dst.dev == dev &&
rt != adn->net->ipv6.ip6_null_entry &&
(rt->rt6i_nsiblings == 0 || netdev_unregistering(dev) ||
- !rt->rt6i_idev->cnf.ignore_routes_with_linkdown))
+ !rt->rt6i_idev->cnf.ignore_routes_with_linkdown)) {
+ rt->rt6i_nh_flags |= (RTNH_F_DEAD | RTNH_F_LINKDOWN);
return -1;
+ }
return 0;
}
OpenPOWER on IntegriCloud