summaryrefslogtreecommitdiffstats
path: root/src/usr/ipmi
Commit message (Collapse)AuthorAgeFilesLines
* ipmi: Split into ipmibase and ipmiext modulesAndrew Jeffery2018-10-1029-10247/+0
| | | | | | | | | | | | | | | | | | Split the IPMI module into base and ext portions, with the BT interface, device driver and resource provider in the base portion, and all remaining IPMI functionality in the ext portion. The split is in preparation for moving the base functionality in the hostboot base image. Change-Id: Iec864f96240d79f4fadd5519d2ef46437d07c1fd Signed-off-by: Andrew Jeffery <andrewrj@au1.ibm.com> Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/66792 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Reviewed-by: Corey V. Swenson <cswenson@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
* ipmi: IpmiDD and IpmiRP must never free resourcesAndrew Jeffery2018-10-104-90/+10
| | | | | | | | | | | | | | | | | | | An IPMI-based PNOR implementation will be introduced in the future. If it is in use (and it likely will be), then IpmiDD and IpmiRP must be functional right up until the shutdown() syscall is invoked. This is necessary because hostboot assumes parts of the PNOR can be paged in at any time (though not necessarily dirtied and flushed), and IPMI is now required to fulfil the requests. Remove the unnecessary shutdown-related code from both classes. Change-Id: I82276e5e12c8b917d655000a456b72a2ccacdb5f Signed-off-by: Andrew Jeffery <andrewrj@au1.ibm.com> Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/67077 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
* ipmi: Terminate SEL task via shutdown eventAndrew Jeffery2018-10-092-33/+11
| | | | | | | | | | | | | | | | | | | | The IpmiSEL task will become part of the extended image once the IPMI module is split in two. Once split, if we need to handle an early shutdown we cannot be referencing code from HBI in HBB. To that end, ensure we don't instantiate an IpmiSEL via Singleton in an attempt to shutdown its event loop when it hasn't been loaded, let alone started. Instead, have IpmiSEL register itself in the shutdown handler, and shut down the SEL task before IpmiRP. Change-Id: I358f6cb1f5528a4ad72c93477ad883cad19e2bf6 Signed-off-by: Andrew Jeffery <andrewrj@au1.ibm.com> Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/67076 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Corey V. Swenson <cswenson@us.ibm.com> Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
* ipmi: Introduce register_for_event() interfaceAndrew Jeffery2018-10-081-0/+6
| | | | | | | | | | | | | | | register_for_event() allows the IPMI PNOR implementation to indicate interest in SELs from the hiomap protocol used for managing the LPC FW space. Change-Id: I3bf6cb7f860d41a0c46755e23fd54276ae2258ff Signed-off-by: Andrew Jeffery <andrewrj@au1.ibm.com> Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/65938 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
* ipmi: Drop unnecessary ipmibt dependency from ipmifruAndrew Jeffery2018-10-081-1/+0
| | | | | | | | | | | Change-Id: I5c0f88f5a95c95928248141b3a8713fb9fe0ed6d Signed-off-by: Andrew Jeffery <andrewrj@au1.ibm.com> Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/66791 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
* ipmi: Drop unnecessary ipmiconfig dependenciesAndrew Jeffery2018-10-083-4/+1
| | | | | | | | | | | | | | Removing the unused include is a cleanup motivated by splitting the ipmi module in two, into parts consisting of the service (DD and RP) and clients (FRU, SEL, etc). Change-Id: Idc4b7c839edda5f23d73a0e0ad8112b2bcbb255d Signed-off-by: Andrew Jeffery <andrewrj@au1.ibm.com> Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/66790 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
* ipmi: Break circular dependency between IpmiDD and IpmiRPAndrew Jeffery2018-10-084-8/+54
| | | | | | | | | | | | | | | | | | | | | | | | | Previously IpmiDD depended on IpmiRP to acquire IpmiRP's message queue for IpmiDD to enqueue hardware state change events. IpmiRP in-turn depends on IpmiDD for shutdown event handling, calling through IpmiDD::handleShutdown() in IpmiRP::shutdownNow(). Break the circular dependency by asynchronously publishing hardware state change events from IpmiDD on a queue owned by IpmiDD. IpmiRP consumes messages from IpmiDD's event queue and republishes them on its own internal queue for consumption by the state management task. This is a little inefficient but provides for greater design clarity in the face of a lack of a select() or poll() style interface that would allow listening for messages on multiple message queues. Change-Id: I3c3c3209d515ec9e90c04630779624bf85e953b1 Signed-off-by: Andrew Jeffery <andrewrj@au1.ibm.com> Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/65936 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Corey V. Swenson <cswenson@us.ibm.com> Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
* Support for extended FRU data for memory modulesMaxim Polyakov2018-10-032-4/+360
| | | | | | | | | | | | | | | | | | | Decode some DIMM SPD fields according to JEDEC format to write detailed info into an IMPI FRU message: 1. Manufacturer field contains real orgainsation name instead of ID. 2. Module name contains type, capacity, speed and other attributes. Change-Id: I869d2fdcdffa40aa0439a119a1327d83931f5ec5 Signed-off-by: Artem Senichev <a.senichev@yadro.com> Signed-off-by: Maxim Polyakov <m.polyakov@yadro.com> Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/66746 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Reviewed-by: William G. Hoffa <wghoffa@us.ibm.com> Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/66902 Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
* ipmi: Replace incorrect dependency on ipmibt with ipmimsgAndrew Jeffery2018-10-021-2/+3
| | | | | | | | | | | | | | No symbols from ipmibt.H were required, but some from ipmimsg.H were. Change-Id: I9730670b5c2686cbf3f55e2b52e91ded3d78cfb0 Signed-off-by: Andrew Jeffery <andrewrj@au1.ibm.com> Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/65935 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Corey V. Swenson <cswenson@us.ibm.com> Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
* ipmi: Break circular dependency between ipmimsg and ipmibtAndrew Jeffery2018-10-022-40/+41
| | | | | | | | | | | | | | | | Implement the message factory in the back-end implementation for which it is producing messages. The linker will resolve the right implementation based on the build configuration. Change-Id: I407f51e239b3dd3795502942cc24d80fbf0ffac6 Signed-off-by: Andrew Jeffery <andrewrj@au1.ibm.com> Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/65934 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Corey V. Swenson <cswenson@us.ibm.com> Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
* Additional tracing for shutdown eventsMatt Derksen2018-09-121-4/+5
| | | | | | | | | | | | | | | | | Hit an issue where a shutdown was called but all that is traced is a msgQ pointer. These traces should help associate the msgQ pointer to an actual task being shutdown. Change-Id: Ic22fdde1a146eec90f26d557e8af1ddec3c85c4e CQ:SW443508 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/65464 Reviewed-by: Christian R. Geddes <crgeddes@us.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Corey V. Swenson <cswenson@us.ibm.com> Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
* Send errors from previous boots as callhome type eSELsNick Bofferding2018-07-171-7/+17
| | | | | | | | | | | | | | | | | | During early boot, Hostboot attempts to resend unacknowledged error logs from prior boots as eSELS, without correponding SELs. BMCs typically require both in order to expose a given error log to a customer. This change morphs errors from prior boots into callhome type logs, so that a simple eSEL will be enough to get the error propagated. Change-Id: If499defe8a39b9254f08392b264d72047b7e5f7c CQ: SW426731 RTC: 193265 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/62079 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: William G. Hoffa <wghoffa@us.ibm.com>
* ipmiwatchdog: Handle uninitialized errors during resetWilliam A. Kennington III2018-07-101-5/+56
| | | | | | | | | | | | | | | | | | | | | The IPMI spec allows for the IPMI watchdog to return an error if the watchdog was never initialized. This can happen if the daemon restarts or if the initial setWatchDog command fails for some reason. Instead of allowing the watchdog to remain uninitialized and disabled, use the values of the previously issued set command to re-initialize the watchdog. This is only attempted once per resetWatchDog call, but periodic calls to the resetWatchDog should eventually re-initialize it. Resolves #139 Signed-off-by: William A. Kennington III <wak@google.com> Change-Id: I7b777e2f3b75d5ce38888018c1b74c6ce12ffc19 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/59163 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
* ipmiwatchdog: Limit the number of resetsWilliam A. Kennington III2018-05-301-0/+14
| | | | | | | | | | | | | | | | | | | | | | | | | We send resets after the completion of every istep and in the middle of some of our known long isteps. In some instances during boot, during fast isteps or custom routines, we can send 10 or more resets within the same second. This generates a lot of IPMI traffic and causes the BMC to spend more time processing resets than is needed. Since our timeout is relatively long (120s right now), it should be no issue to limit the number of resets to one reset every 1-2 seconds I've tested this on a zaius machine and it reduced load on the BMC and made clean boots a little faster. Resolves #140 Signed-off-by: William A. Kennington III <wak@google.com> Change-Id: I60d26af082e1ddb29624fc22a0513b47526978d5 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/59291 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Reviewed-by: William G. Hoffa <wghoffa@us.ibm.com>
* Get SN from BMC and update into PVPD EEPROMMeng Li2018-05-194-5/+230
| | | | | | | | | | | | Resolves #135 Change-Id: I46b5c2208ed28822c6001a955f4056d976e79339 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/58010 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
* Fix FRU board mfg date and time.Jim Yuan2018-05-171-7/+14
| | | | | | | | | | | | | | | | VPD data is in BCD format and needs translation. Resolves #138 Signed-off-by: Jim Yuan <jim.yuan@supermicro.com> Change-Id: Ib3de6a7cc75876bc04930643c02bfc7734723db5 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/58945 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com> Reviewed-by: William G. Hoffa <wghoffa@us.ibm.com>
* Enable super-long watchdog timer when console traces are enabledDan Crowell2018-05-022-1/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | When console traces are enabled, the boot takes significantly longer than usual. Our standard watchdog timeout of 2 minutes is not sufficient. Made the following changes: - Tied the enablement of the long timeout to the CONFIG flags for console traces - Increased the timeout to 1 hour (from 40 minutes) since this is lab only and false positives are the worst... - Added a couple clarifying traces to make future watchdog debug simpler Change-Id: I92bb0b07cb77a13cb390450999b285f2ad74168d CQ: SW425407 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/57580 Reviewed-by: Martin Gloff <mgloff@us.ibm.com> Reviewed-by: Richard J. Knight <rjknight@us.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Christian R. Geddes <crgeddes@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Reviewed-by: William G. Hoffa <wghoffa@us.ibm.com>
* Fix setting hbVolatile and RebootControl sensorsMatt Derksen2018-01-161-5/+7
| | | | | | | | | | | | | | | | Setting sensor to 2 equates to BMC setting of 1, Setting sensor to 1 equates to BMC setting of 0. Change-Id: Ib3c4b4a144a8fad5bd4f93be88bbe0ff7476ab64 RTC: 180772 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/51787 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Reviewed-by: Adriana Kobylak <anoo@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Christian R. Geddes <crgeddes@us.ibm.com> Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
* Add HB_VOLATILE sensor so OpenBMC can mark volatile sectionsMatt Derksen2017-12-211-0/+79
| | | | | | | | | | | | | | | | Set sensor to 1 to tell OpenBMC code to allow hostboot volatile section to be cleared. RTC: 180772 Change-Id: Id63e3ae8a24facd5e01e8bf94688a60f066ba838 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/51101 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Reviewed-by: Martin Gloff <mgloff@us.ibm.com> Reviewed-by: Christian R. Geddes <crgeddes@us.ibm.com> Reviewed-by: William G. Hoffa <wghoffa@us.ibm.com>
* Fix grabbing config from NV keyword dataMatt Derksen2017-11-151-9/+33
| | | | | | | | | | | | | | | | getGPUSensors was returning INVALID_IPMI_SENSOR for all GPUs as it was incorrectly reading the NV config ID. Change-Id: Iab71302f2066304dbf17e4fafcde0af8ca3c1240 CQ: SW407191 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/49615 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Reviewed-by: Martin Gloff <mgloff@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Brian E. Bakke <bbakke@us.ibm.com> Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
* Fix some review comments for sending down OCC info logs to BMCMatt Derksen2017-11-091-1/+3
| | | | | | | | | | | | | | Change-Id: I9ed25562af671a6df34746d5900e781ff1dcc517 RTC:180324 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/49366 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Reviewed-by: Brian E. Bakke <bbakke@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Elizabeth K. Liner <eliner@us.ibm.com> Reviewed-by: Christian R. Geddes <crgeddes@us.ibm.com> Reviewed-by: William G. Hoffa <wghoffa@us.ibm.com>
* Send down OCC info logs to BMC for call-homeMatt Derksen2017-11-091-16/+28
| | | | | | | | | | | | | | | | | | This creates a new eSEL type (dd) to display informational callhome logs. The OCC will send down telemetry information to track the general health of the system using this new log. Change-Id: I0319798554c4e48c287953bd2d0de8352bfc4909 RTC:180324 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/48776 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Brian E. Bakke <bbakke@us.ibm.com> Reviewed-by: Christian R. Geddes <crgeddes@us.ibm.com> Reviewed-by: William G. Hoffa <wghoffa@us.ibm.com>
* Control Host reboots for manufacturingDean Sanner2017-11-061-0/+82
| | | | | | | | | | | | | | | | | | | | | | In a manufacturing environment it is desired to reboot once (and only once) to get the FIRDATA analysis on checkstop. This commit adds functionality to control the auto reboot policy on the BMC. It then "remembers" the state using the HB VOLATILE PNOR partition to enable reboots when in MFG mode. Note that when in this mode, any reboot (even from host) will terminate the boot. Change-Id: If5ce133b59e10c659d7024d1ae08a40988e35190 RTC:180772 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/48116 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Corey V. Swenson <cswenson@us.ibm.com> Reviewed-by: Dean Sanner <dsanner@us.ibm.com> Reviewed-by: Christian R. Geddes <crgeddes@us.ibm.com>
* ipmi: add support for reading SEL time from BMCRobert Lippert2017-10-301-1/+22
| | | | | | | | | | | | | | | | | The SEL time is used as the equivalent of the RTC on OpenPOWER platforms and can be used to timestamp events. Resolves #116 Signed-off-by: Robert Lippert <rlippert@google.com> Change-Id: I2cc7f3054e0d58fa3e2d083005d0f4e05adf8d2f Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/48375 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Reviewed-by: Richard J. Knight <rjknight@us.ibm.com> Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
* Set variables to nullptr after they are deletedChristian Geddes2017-09-252-0/+3
| | | | | | | | | | | | | | | | | | While updating some LPC logic a developer noticed a bug where an errlog handle wasnt getting set to nullptr after it was deleted this caused a confusing bug that took awhile to track. I noticed that this bug was all over our code so this commit fixes a lot of cases where variables get deleted but not set to nullptr Change-Id: I103b5c71b93686c3c89b04d1d565a24d4de74e6f Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/45890 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: William G. Hoffa <wghoffa@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Reviewed-by: Matt Derksen <mderkse1@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
* Add sensor name to IPMI sensor error logsDan Crowell2017-09-121-5/+12
| | | | | | | | | | | | Change-Id: I5a71cb466d683d9a77a6c905ac33fa21a1d5d348 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/45315 Reviewed-by: Elizabeth K. Liner <eliner@us.ibm.com> Reviewed-by: Matt Derksen <mderkse1@us.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Reviewed-by: William G. Hoffa <wghoffa@us.ibm.com>
* Small cleanup for OCC/HTMGT GPU sensor supportMatt Derksen2017-09-061-7/+8
| | | | | | | | | | | | | | | Made const more generic instead of system specific Change-Id: I6229c727428c0c077d335e5c1eb66e06651ea39d RTC:178218 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/45654 Reviewed-by: Martin Gloff <mgloff@us.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Reviewed-by: Christian R. Geddes <crgeddes@us.ibm.com> Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
* New OCC/HTMGT interfaces for GPU sensor supportMatt Derksen2017-09-052-1/+369
| | | | | | | | | | | | | | | getGpuSensors() and updateGpuSensorStatus() Depends-on: I8a0de390516fd02df07860b960db506899b13f14 Change-Id: I290876d0e5f4889e6f2b1a45b5f81172acb28caf RTC:178218 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/45196 Reviewed-by: Martin Gloff <mgloff@us.ibm.com> Reviewed-by: Christian R. Geddes <crgeddes@us.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
* Added Error log support for new GPU sensorsMatt Derksen2017-09-011-0/+83
| | | | | | | | | Change-Id: I8a0de390516fd02df07860b960db506899b13f14 RTC:178218 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/45116 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
* Secure Boot: Shutdown after key transitionNick Bofferding2017-07-282-12/+38
| | | | | | | | | | | | | | | | | | - Fence off istep path after istep dispatcher stops - Automatically power off after a key transition has completed - Added IPMI API to power off system Change-Id: I74eaec08e86d0cbc46db6aa1674845c53bcf14d4 RTC: 174017 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/43436 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Michael Baiocchi <mbaiocch@us.ibm.com> Reviewed-by: Marshall J. Wilks <mjwilks@us.ibm.com> Reviewed-by: Stephen M. Cprek <smcprek@us.ibm.com> Reviewed-by: William G. Hoffa <wghoffa@us.ibm.com>
* Replaced calls to bmc for sensor type with static information.Donald Washburn2017-06-272-1/+386
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The sendErrLogToBMC function was calling to the bmc in order to determine the type of a sensor based upon a sensor number. It was determined that the sensor type can be obtained from the sensor number by data loaded during initialization via the TARGETING namespace. The ipmi call from SenorBase::getSensorType was removed from the sendErrLogToBMC function and replaced with a call to IpmiConfigLookup::getSensorType. The getSensorType function from the new IpmiConfigLookup class retrieves sensor data from target attributes and as such does not call the bmc for the type information. * Added the new IpmiConfigLookup class in the IPMI namespace. This class provides static methods to retrive sensor data provided by the IPMI_SENSOR target attribute. In addition to sensor type, the sensor entity id and sensor name can be obtined from this class based upon a sensor number. * Changed sendErrLogToBMC to call IpmiConfigLookup::getSensorType instead of Sensor::SensorBase::getSensorInfo. RTC: 164493 Change-Id: Ie8e7fa5c37fa972d6cecd1e4b69e2d0cb7504533 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/42128 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Prachi Gupta <pragupta@us.ibm.com> Reviewed-by: ILYA SMIRNOV <ismirno@us.ibm.com> Reviewed-by: Richard J. Knight <rjknight@us.ibm.com> Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
* Add leap year and days of month into build date for ipmi fru invMatt Ploetz2017-05-222-8/+40
| | | | | | | | | | | | | Change-Id: I6c378db6aad5cc1ff2d93d2a220e8dbc4a934f7b RTC:172125 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/40664 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: William G. Hoffa <wghoffa@us.ibm.com> Reviewed-by: ILYA SMIRNOV <ismirno@us.ibm.com> Reviewed-by: Prachi Gupta <pragupta@us.ibm.com> Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
* Support manufacturing date VPD in IPMI fru inventoryMatt Ploetz2017-05-022-11/+161
| | | | | | | | | | | | Change-Id: Iab5d8d5fdc0a9c361de9f28348719c36fcddb827 RTC: 158892 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/38365 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Reviewed-by: Prachi Gupta <pragupta@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: William G. Hoffa <wghoffa@us.ibm.com> Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
* Revert "Sending Firmware progress sensor is now synchronous"William G. Hoffa2017-02-271-40/+1
| | | | | | | | | | | | This reverts commit 9b188cdec934275ce65eab3ade91398fdec4ddb9. Change-Id: I6e61680c204734638b03f628abb1d0e4d4f590e8 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/36983 Reviewed-by: STEWART E. SMITH <stewart@linux.vnet.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Reviewed-by: William G. Hoffa <wghoffa@us.ibm.com>
* OP820:OPRASGS:Garrison:Hostboot IPL fails to halt during shutdown reconfigRichard J. Knight2017-02-072-2/+50
| | | | | | | | | | | | | | | | | | | | | -Added the ability to notify the istep dispacher discontinue executing isteps -Added call to stopIpl() api in sbe update path -Added internal graceful reboot request for SBE update and reconfigure re-ipl usage Change-Id: I5682992802b0f373df91378a38187d032bb3a0b4 CQ:SW361886 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/27959 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Reviewed-by: William G. Hoffa <wghoffa@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Matthew A. Ploetz <maploetz@us.ibm.com> Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/28574 Reviewed-by: Dean Sanner <dsanner@us.ibm.com>
* generate errl for missing IPMI sensor number instead of assertRobert Lippert2017-01-041-2/+20
| | | | | | | | | | | Change-Id: I23310799e35e8d58ff23805ee988d4ff8f3fa5e3 Signed-off-by: Robert Lippert <rlippert@google.com> Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/33980 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: William G. Hoffa <wghoffa@us.ibm.com> Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
* HTMGT: OCC InitializationAndres Lugo-Reyes2016-12-091-1/+1
| | | | | | | | | | | | | | | | | Contains the changes for p9 OCC init. Mostly a port from p8. New cmd/rsp buffers and data format for packets. This commit also makes HTMGT fapi2 compatible. Change-Id: I6182163e569ac97f06e3ddfbb69deab90e849de3 RTC:133945 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/31010 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Reviewed-by: Martin Gloff <mgloff@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Reviewed-by: Christopher J. Cain <cjcain@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: William G. Hoffa <wghoffa@us.ibm.com>
* Adding interface changes to provide BMC information to HDATElizabeth Liner2016-10-193-34/+46
| | | | | | | | | | | Change-Id: I3ad70f2886fe8c0fc420bf490effbde33e477010 RTC:161648 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/30994 Reviewed-by: VENKATESH SAINATH <venkatesh.sainath@in.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: William G. Hoffa <wghoffa@us.ibm.com> Reviewed-by: Matthew A. Ploetz <maploetz@us.ibm.com>
* Add interfaces for HDAT to fetch new dataDan Crowell2016-10-161-0/+11
| | | | | | | | | | | | | | | | | | New interfaces added: I2C::getDeviceInfo() IPMI::getBmcInfo() CONSOLE::getUartInfo() New attributes: SYSTEM_FAMILY SYSTEM_TYPE Change-Id: I7d1a018c01067a19b8a66f853e11922c910fcc54 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/30405 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Reviewed-by: Elizabeth K. Liner <eliner@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
* Fix for setting IPMI_MAX_BUFFER_SIZE attributeCorey Swenson2016-07-241-11/+11
| | | | | | | | | | | | | | | | | | Change-Id: I34ae9ee877dbb2219bd0dda4deba76b2c01901e2 CQ:SW354308 ForwardPort: yes Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/25405 Tested-by: Jenkins Server Reviewed-by: Richard J. Knight <rjknight@us.ibm.com> Tested-by: Jenkins OP Build CI Tested-by: Jenkins OP HW Tested-by: FSP CI Jenkins Reviewed-by: William G. Hoffa <wghoffa@us.ibm.com> Reviewed-by: Matthew A. Ploetz <maploetz@us.ibm.com> Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/25736 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
* Trustedboot PCR Extend reworked to use task message queueChris Engel2016-07-181-2/+2
| | | | | | | | | | | | | | Removed TPM log manager and required functions from HBB and replaced with a simple message queue Change-Id: I5f5a418b6ea8c0228229e8c45523385b488e2b6b RTC: 155519 ForwardPort: yes Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/27133 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Christopher J. Engel <cjengel@us.ibm.com> Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
* Avoid visible errors during SBE updatePrasad Bg Ranganath2016-07-182-1/+83
| | | | | | | | | | RTC: 135822 Backport: yes Change-Id: I9581abc5f1d0cb4812743190c9914b11c63c0089 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/764 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
* DDR4 - Allow SPD writesaalugore2016-04-211-1/+2
| | | | | | | | | | | | | | | | | | | -DDR4 has 512-byte EEPROM with 2 256-byte pages. This commit contains the necessary page switching logic to support this. Change-Id: Iaa8e3e344def98b71d6a9e9387c5e0d9137a0397 RTC:137707 ForwardPort: yes Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/797 Tested-by: Jenkins Server Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com> Tested-by: Jenkins OP Build CI Reviewed-by: William G. Hoffa <wghoffa@us.ibm.com> Tested-by: Jenkins OP HW Tested-by: FSP CI Jenkins Reviewed-by: Matthew A. Ploetz <maploetz@us.ibm.com> Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/871
* Sending Firmware progress sensor is now synchronousAndres Lugo-Reyes2016-03-211-0/+39
| | | | | | | | | | | | | | | | Change-Id: I22dc54cc4472958aec35a23d91740106be0be928 CQ:SW336181 ForwardPort:yes Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/21902 Tested-by: Jenkins Server Reviewed-by: Prachi Gupta <pragupta@us.ibm.com> Reviewed-by: Richard J. Knight <rjknight@us.ibm.com> Tested-by: Jenkins OP Build CI Tested-by: Jenkins OP HW Reviewed-by: Jay M. Azurin <jmazurin@us.ibm.com> Tested-by: FSP CI Jenkins Reviewed-by: William G. Hoffa <wghoffa@us.ibm.com> Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/22300
* Ensure ipmiSel thread finishes before shutting down ipmiddMatt Ploetz2016-03-172-20/+39
| | | | | | | | | | | | | | Change-Id: I07a5ea99e5e5c5672bf889689b25551b9c95b0ff CQ:SW328077 ForwardPort:yes Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/21876 Tested-by: Jenkins Server Tested-by: Jenkins OP Build CI Tested-by: Jenkins OP HW Reviewed-by: A. P. Williams III <iawillia@us.ibm.com> Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/22151 Tested-by: FSP CI Jenkins Reviewed-by: Matthew A. Ploetz <maploetz@us.ibm.com>
* Adding chip DD/EC levels to FRU inventoryElizabeth Liner2016-03-022-10/+61
| | | | | | | | | | | | | | | Change-Id: Ibed8e8ed630db69d20778e1a9b21b6becd307f7a RTC:124665 ForwardPort: yes Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/20669 Tested-by: Jenkins Server Tested-by: Jenkins OP Build CI Tested-by: Jenkins OP HW Tested-by: FSP CI Jenkins Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com> Reviewed-by: Richard J. Knight <rjknight@us.ibm.com> Reviewed-by: William G. Hoffa <wghoffa@us.ibm.com> Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/21616
* DIMM Present sensor not active after dimm is deconfiguredRichard J. Knight2016-02-241-2/+16
| | | | | | | | | | | | | | | | | | -Modified set sensor reading command to not use the bit by default in the operation field which triggers the BMC to overwrite the existing assertion mask. -Updated the reboot count sensor to use the operation specified by AMI to overwrite existing data in assertion mask field. Fixes open-power/hostboot#47 Change-Id: I81958225480f495f8b0d4f523d0c8109832475f6 CQ:SW328073 Reviewed-on: http://gfw160.aus.stglabs.ibm.com:8080/gerrit/23947 Tested-by: Jenkins Server Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
* No data in System_Event SEL to decode procedure calloutsPrasad Bg Ranganath2016-02-191-51/+105
| | | | | | | | Change-Id: I21d3bd2089e1db460a5d41b874bf1b1ab98ca8bf CQ: SW328277 Reviewed-on: http://gfw160.aus.stglabs.ibm.com:8080/gerrit/22578 Tested-by: Jenkins Server Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
* Set watchdog and set sensors are now asynchronous sendsElizabeth Liner2016-02-193-47/+44
| | | | | | | | | | | Backport: master-p8 Change-Id: If8741e67986c6d6df95a655fb5669df764649e82 Reviewed-on: http://gfw160.aus.stglabs.ibm.com:8080/gerrit/18993 Tested-by: Jenkins Server Reviewed-by: Brian Silver <bsilver@us.ibm.com> Reviewed-by: Richard J. Knight <rjknight@us.ibm.com> Reviewed-by: WILLIAM G. HOFFA <wghoffa@us.ibm.com> Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
* SW328412 - Multiple SELs per eSELBen Rafanello2016-02-191-2/+5
| | | | | | | | | | | | | | | | | | | | | | | The problem being fixed is the generation of multiple SELs per eSEL when sending of the eSEL to the BMC fails due to loss of SEL reservation on the BMC. The code in send_esel is not supposed to generate the SEL if there was an error sending the eSEL(the eSEL is in the log stored on the PNOR and will be sent after the next reboot if it has not been marked as having been sent to the BMC). The error is that there are two error variables that need to be checked in order to determine if there was an error sending the eSEL to the BMC. The code was only checking one of those. Change-Id: I1346b29d8c31ed862b0bcfba9a6b8f057030ac20 CQ:SW328412 backport:master-p8 Reviewed-on: http://gfw160.aus.stglabs.ibm.com:8080/gerrit/22663 Tested-by: Jenkins Server Reviewed-by: WILLIAM G. HOFFA <wghoffa@us.ibm.com> Reviewed-by: Marshall J. Wilks <mjwilks@us.ibm.com> Reviewed-by: A. Patrick Williams III <iawillia@us.ibm.com>
OpenPOWER on IntegriCloud