summaryrefslogtreecommitdiffstats
path: root/src/usr
diff options
context:
space:
mode:
authorDan Crowell <dcrowell@us.ibm.com>2016-03-31 10:26:22 -0500
committerDaniel M. Crowell <dcrowell@us.ibm.com>2016-03-31 18:13:59 -0400
commit3d4ff0736829e9ddad861615e0192b4fe1478cb1 (patch)
tree5b60e17642303bf8ace3ca7d34250306489ab76d /src/usr
parent6d03721de46c3ed7355f8f4938c0869a087ae876 (diff)
downloadblackbird-hostboot-3d4ff0736829e9ddad861615e0192b4fe1478cb1.tar.gz
blackbird-hostboot-3d4ff0736829e9ddad861615e0192b4fe1478cb1.zip
Handle non-platInit temporary attributes
A fapi attribute that is not platInit must be associated with a volatile-zeroed persistency, rather than volatile. Change-Id: Id5d3193e07158bc42c98f1bd2c8e9fdb2ee6b1b5 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/22713 Tested-by: Jenkins Server Reviewed-by: Martin Gloff <mgloff@us.ibm.com> Tested-by: Daniel M. Crowell <dcrowell@us.ibm.com> Tested-by: FSP CI Jenkins Reviewed-by: Nicholas E. Bofferding <bofferdn@us.ibm.com> Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
Diffstat (limited to 'src/usr')
-rwxr-xr-xsrc/usr/targeting/xmltohb/updatetempsxml.pl11
1 files changed, 9 insertions, 2 deletions
diff --git a/src/usr/targeting/xmltohb/updatetempsxml.pl b/src/usr/targeting/xmltohb/updatetempsxml.pl
index f8bd350b6..0777e489c 100755
--- a/src/usr/targeting/xmltohb/updatetempsxml.pl
+++ b/src/usr/targeting/xmltohb/updatetempsxml.pl
@@ -164,6 +164,8 @@ foreach my $TempAttr ( @{$fwDfltsXml->{attribute}} )
$generic_id =~ s/ATTR_//;
my $found = 0;
+ my $persistency = "volatile";
+
# First, check if attribute definition exists in fapiattrs.xml
foreach my $FapiAttr ( @{$fapiXml->{attribute}} )
{
@@ -214,6 +216,13 @@ foreach my $TempAttr ( @{$fwDfltsXml->{attribute}} )
}
}
+ # Non-platInit attributes need to be volatile-zeroed
+ # or xmltohb.pl will throw an error
+ if( !(exists $FapiAttr->{platInit}) )
+ {
+ $persistency = "volatile-zeroed";
+ }
+
last;
}
}
@@ -282,8 +291,6 @@ foreach my $TempAttr ( @{$fwDfltsXml->{attribute}} )
}
}
- my $persistency = "volatile";
-
# Create enumeration definition to support generic attribute if FAPI
# attribute associated with temp FW default uses enum
my $enum_id = "";
OpenPOWER on IntegriCloud