diff options
| author | Matt Derksen <mderkse1@us.ibm.com> | 2019-03-29 09:40:17 -0500 |
|---|---|---|
| committer | Daniel M. Crowell <dcrowell@us.ibm.com> | 2019-04-04 16:58:05 -0500 |
| commit | f68a45ca56945112b72edd3d7cea2744e280e4d9 (patch) | |
| tree | f025f232ac130d0a2e7573a57512ddaa2a0f3048 /src/usr/targeting | |
| parent | 9291b67c357d4dca66bf2e969a153e854fe13f23 (diff) | |
| download | blackbird-hostboot-f68a45ca56945112b72edd3d7cea2744e280e4d9.tar.gz blackbird-hostboot-f68a45ca56945112b72edd3d7cea2744e280e4d9.zip | |
Small cleanup of NVDIMM update
Changes made based on review comments.
- Needed to make some errors purely software errors.
- Removed error if running on non-FSP system.
- Make it clear that writeCycleTime is NOT used.
Change-Id: Iac4acdda46bfcdb35c8ce7f3a1d1541f8c560957
RTC:202536
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/75229
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
Reviewed-by: TSUNG K. YEUNG <tyeung@us.ibm.com>
Reviewed-by: Corey V. Swenson <cswenson@us.ibm.com>
Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
Diffstat (limited to 'src/usr/targeting')
| -rwxr-xr-x | src/usr/targeting/common/genHwsvMrwXml.pl | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/src/usr/targeting/common/genHwsvMrwXml.pl b/src/usr/targeting/common/genHwsvMrwXml.pl index 72e5e9b05..adc8d179a 100755 --- a/src/usr/targeting/common/genHwsvMrwXml.pl +++ b/src/usr/targeting/common/genHwsvMrwXml.pl @@ -6142,6 +6142,7 @@ sub generate_is_dimm # Add EEPROM_NV_INFO i2c config # Base address for the NV controller is 0x80 # piggybacking the last nibble of devAddr from $dimmI2C to build the device address + # NOTE: writeCycleTime is not used for NV as code update needs it at a faster rate then msec print " <attribute> <id>EEPROM_NV_INFO</id> @@ -6154,7 +6155,7 @@ sub generate_is_dimm <field><id>maxMemorySizeKB</id><value>0x01</value></field> <field><id>chipCount</id><value>0x01</value></field> <field><id>writePageSize</id><value>0x01</value></field> - <field><id>writeCycleTime</id><value>0x05</value></field> + <field><id>writeCycleTime</id><value>0xFFBADFFBADFFBADF</value></field> </default> </attribute> "; @@ -7125,7 +7126,7 @@ sub addI2cBusSpeedArray my $tmp_ct eq ""; # bus_speed_array[engine][port] is 4x13 array - # Hardcoding speed_array[3][1] for nvdimm as NVDIMM is current + # Hardcoding speed_array[3][1] for nvdimm as NVDIMM is current # not in mrw for ZZ (last gen of serverwiz1) my @speed_array = (0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, |

