diff options
author | Dan Crowell <dcrowell@us.ibm.com> | 2018-08-20 16:35:49 -0500 |
---|---|---|
committer | William G. Hoffa <wghoffa@us.ibm.com> | 2018-10-02 08:57:58 -0500 |
commit | 46b6d71b01b4936cfdf1e3236cde199a3940a231 (patch) | |
tree | f413bdd97c15a311b154a971a7338ef3d0772f25 /src/usr/targeting/runtime | |
parent | 01fcdb647ea0a6c899b9de21ed144f16dc2f2afb (diff) | |
download | blackbird-hostboot-46b6d71b01b4936cfdf1e3236cde199a3940a231.tar.gz blackbird-hostboot-46b6d71b01b4936cfdf1e3236cde199a3940a231.zip |
Add consistent enter-exit traces for all runtime interfaces
Created a new 'HBRT' trace buffer that is exclusively used to
bound the external calls into our runtime image.
Modified the return code values to be the reasoncode of the error
log we commit instead of a generic '-1' value that is not
very helpful.
Change-Id: Id41288ea1903bf6d11e967fcb10a8184153943c8
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/64871
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Reviewed-by: Brian J. Stegmiller <bjs@us.ibm.com>
Reviewed-by: Matt Derksen <mderkse1@us.ibm.com>
Reviewed-by: William G. Hoffa <wghoffa@us.ibm.com>
Diffstat (limited to 'src/usr/targeting/runtime')
-rw-r--r-- | src/usr/targeting/runtime/attrPlatOverride_rt.C | 3 | ||||
-rw-r--r-- | src/usr/targeting/runtime/rt_targeting.C | 5 |
2 files changed, 8 insertions, 0 deletions
diff --git a/src/usr/targeting/runtime/attrPlatOverride_rt.C b/src/usr/targeting/runtime/attrPlatOverride_rt.C index a803b5323..b379313d9 100644 --- a/src/usr/targeting/runtime/attrPlatOverride_rt.C +++ b/src/usr/targeting/runtime/attrPlatOverride_rt.C @@ -39,6 +39,7 @@ #include <sys/internode.h> +extern trace_desc_t* g_trac_hbrt; using namespace TARGETING; namespace RT_TARG @@ -50,6 +51,7 @@ int apply_attr_override(uint8_t* i_data, int rc = 0; errlHndl_t l_errl = NULL; + TRACFCOMP(g_trac_hbrt, ENTER_MRK" apply_attr_override"); TRACFCOMP(g_trac_targeting, "enter apply_attr_override"); bool l_allowOverrides = true; @@ -122,6 +124,7 @@ int apply_attr_override(uint8_t* i_data, #endif } + TRACFCOMP(g_trac_hbrt, EXIT_MRK" apply_attr_override: rc=%d"); return rc; } diff --git a/src/usr/targeting/runtime/rt_targeting.C b/src/usr/targeting/runtime/rt_targeting.C index 06342633e..35d154f2d 100644 --- a/src/usr/targeting/runtime/rt_targeting.C +++ b/src/usr/targeting/runtime/rt_targeting.C @@ -48,6 +48,7 @@ #include <sys/internode.h> +extern trace_desc_t* g_trac_hbrt; using namespace TARGETING; namespace RT_TARG @@ -711,6 +712,8 @@ errlHndl_t saveRestoreAttrs(void *i_rsvdMemPtr, int hbrt_update_prep(void) { + TRACFCOMP(g_trac_hbrt, ENTER_MRK" prepare_hbrt_update"); + TRACFCOMP(g_trac_targeting, ENTER_MRK" hbrt_update_prep"); errlHndl_t pError = nullptr; UtilLidMgr l_lidMgr(Util::TARGETING_BINARY_LIDID); void *l_lidStructPtr = nullptr; @@ -872,6 +875,8 @@ int hbrt_update_prep(void) errlCommit(pError,TARG_COMP_ID); } + TRACFCOMP(g_trac_targeting, EXIT_MRK" hbrt_update_prep"); + TRACFCOMP(g_trac_hbrt, EXIT_MRK" prepare_hbrt_update: rc=%.X", rc); return rc; } |