Fix HBRT Adjunct Hang due to Multi-Node Sync System Attributes Bugs

Make fixes to the sync system attributes block of code that caused it to make
the HBRT adjunct partition fail with one of various symptoms including a crash,
stack corruption, or HBRT command failing.

Also refactor the getNextTarget() code to reduce additional tracing that was
added recently since too many traces are being generated.

Change-Id: I0d51d3a20ac87ce4b3378310b2164d20a185d76f
RTC: 190816
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/57278
Reviewed-by: Christian R. Geddes <crgeddes@us.ibm.com>
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
Reviewed-by: Prachi Gupta <pragupta@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Reviewed-by: William G. Hoffa <wghoffa@us.ibm.com>
Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>

1 files changed, 5 insertions, 0 deletions

diff --git a/src/usr/targeting/runtime/attrrp_rt.C b/src/usr/targeting/runtime/attrrp_rt.C
index 9f8cce8a6..55be8eaf9 100644
--- a/src/usr/targeting/runtime/attrrp_rt.C
+++ b/src/usr/targeting/runtime/attrrp_rt.C
@@ -332,6 +332,8 @@ namespace TARGETING
                 if(iv_nodeContainer[i_nodeId].pTargetMap == nullptr)
                 {
                     // Locate targeting image for this node in reserved memory
+                    TARG_INF("getTargetMapPtr Locating reserved memory "
+                             "targeting image for the node %d", i_nodeId);
                     uint64_t attr_size = 0;
                     iv_nodeContainer[i_nodeId].pTargetMap =
                         reinterpret_cast<void*>(
@@ -366,6 +368,7 @@ namespace TARGETING
                 else
                 {
                     // This should return pTargetMap from here
+                    l_pTargetMap = iv_nodeContainer[i_nodeId].pTargetMap;
                     break;
                 }
             } while(0);
@@ -382,6 +385,8 @@ namespace TARGETING
             errlCommit(l_errl, TARG_COMP_ID);
         }
 
+        TARG_DBG("getTargetMapPtr returning %p for node %d",
+                 l_pTargetMap, i_nodeId);
         return l_pTargetMap;
         #undef TARG_FN
     }