diff options
| author | Mike Baiocchi <mbaiocch@us.ibm.com> | 2018-06-21 08:16:37 -0500 |
|---|---|---|
| committer | William G. Hoffa <wghoffa@us.ibm.com> | 2018-07-03 17:13:07 -0400 |
| commit | 1759af757bd8f9a13386c4fb4624bd93394af67b (patch) | |
| tree | 630cbf001cf10a15a9c2f939c3c2ec71f2f44808 /src/usr/secureboot/node_comm/node_comm_dd.C | |
| parent | e5dfc3ab0ec51ee63205c7064b7b4a4c4b8ba46f (diff) | |
| download | blackbird-hostboot-1759af757bd8f9a13386c4fb4624bd93394af67b.tar.gz blackbird-hostboot-1759af757bd8f9a13386c4fb4624bd93394af67b.zip | |
Add error callouts and other improvements for Node Communications
This code adds bus, hw, code, etc callouts to the appropriate errors.
It also cleans up other TODOs, refactors some functions, and applies
somes fixes found in testing.
Change-Id: I462cdb2c4e313c277a3e0542f740e82ede3313f3
RTC:184518
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/61813
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Reviewed-by: William G. Hoffa <wghoffa@us.ibm.com>
Diffstat (limited to 'src/usr/secureboot/node_comm/node_comm_dd.C')
| -rw-r--r-- | src/usr/secureboot/node_comm/node_comm_dd.C | 38 |
1 files changed, 16 insertions, 22 deletions
diff --git a/src/usr/secureboot/node_comm/node_comm_dd.C b/src/usr/secureboot/node_comm/node_comm_dd.C index a94454507..dd494ebaf 100644 --- a/src/usr/secureboot/node_comm/node_comm_dd.C +++ b/src/usr/secureboot/node_comm/node_comm_dd.C @@ -418,16 +418,14 @@ errlHndl_t ncddWrite (node_comm_args_t & i_args) i_args.tgt_huid); // Likely an issue with Processor or its bus - err->addHwCallout( i_args.tgt, - HWAS::SRCI_PRIORITY_HIGH, - HWAS::DELAYED_DECONFIG, - HWAS::GARD_NULL ); + addNodeCommBusCallout(i_args.mode, + i_args.tgt, + i_args.linkId, + err); // Or HB code failed to do the procedure correctly err->addProcedureCallout(HWAS::EPUB_PRC_HB_CODE, - HWAS::SRCI_PRIORITY_MED); - - // @TODO RTC 184518 - Look into bus callouts + HWAS::SRCI_PRIORITY_LOW); break; } @@ -512,18 +510,16 @@ errlHndl_t ncddCheckStatus (node_comm_args_t & i_args, i_args.tgt_huid); // Likely an issue with Processor or its bus - err->addHwCallout( i_args.tgt, - HWAS::SRCI_PRIORITY_HIGH, - HWAS::DELAYED_DECONFIG, - HWAS::GARD_NULL ); + addNodeCommBusCallout(i_args.mode, + i_args.tgt, + i_args.linkId, + err); // Or HB code failed to do the procedure correctly err->addProcedureCallout(HWAS::EPUB_PRC_HB_CODE, - HWAS::SRCI_PRIORITY_MED); - - // @TODO RTC 184518 - Look into bus callouts + HWAS::SRCI_PRIORITY_LOW); - break; + break; } @@ -612,16 +608,14 @@ errlHndl_t ncddWaitForCmdComp (node_comm_args_t & i_args, i_args.tgt_huid)); // Likely an issue with Processor or its bus - err->addHwCallout(i_args.tgt, - HWAS::SRCI_PRIORITY_HIGH, - HWAS::DELAYED_DECONFIG, - HWAS::GARD_NULL); + addNodeCommBusCallout(i_args.mode, + i_args.tgt, + i_args.linkId, + err); // Or HB code failed to do the procedure correctly err->addProcedureCallout(HWAS::EPUB_PRC_HB_CODE, - HWAS::SRCI_PRIORITY_MED); - - // @TODO RTC 184518 - Look into bus callouts + HWAS::SRCI_PRIORITY_LOW); break; } |
