summaryrefslogtreecommitdiffstats
path: root/src/usr/mbox
diff options
context:
space:
mode:
authorChristian Geddes <crgeddes@us.ibm.com>2018-09-06 11:13:04 -0500
committerChristian R. Geddes <crgeddes@us.ibm.com>2018-09-10 10:05:45 -0500
commit9b9a992ef2457f2d3fcb4189a32bc78d50bc8669 (patch)
tree1fc56633d281f8e3b61246b014d7e3009517ed74 /src/usr/mbox
parentc16e0b97bd2226d63a93a2dec286a5d3f49f71e7 (diff)
downloadblackbird-hostboot-9b9a992ef2457f2d3fcb4189a32bc78d50bc8669.tar.gz
blackbird-hostboot-9b9a992ef2457f2d3fcb4189a32bc78d50bc8669.zip
Turn off core xstop escalalation on slave nodes prior payload handoff
There was a bug in the code where we only were turning off core xstop escalation on the master node. This is because we were not using IPC to tell slave nodes they also need to do this. This commit re-adds the enableCoreCheckstop function to istep21 and adds it to part of the IPC_START_PAYLOAD message handler so this will happen prior to shutdown on all nodes. Change-Id: I0b601f379635107c851d6fc723b75a0ba21d1016 CQ: SW444801 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/65768 Reviewed-by: Dean Sanner <dsanner@us.ibm.com> Reviewed-by: William G. Hoffa <wghoffa@us.ibm.com> Reviewed-by: Nicholas E. Bofferding <bofferdn@us.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Christian R. Geddes <crgeddes@us.ibm.com>
Diffstat (limited to 'src/usr/mbox')
-rw-r--r--src/usr/mbox/ipcSp.C14
1 files changed, 10 insertions, 4 deletions
diff --git a/src/usr/mbox/ipcSp.C b/src/usr/mbox/ipcSp.C
index aa6b626aa..150ca7a8f 100644
--- a/src/usr/mbox/ipcSp.C
+++ b/src/usr/mbox/ipcSp.C
@@ -48,6 +48,7 @@ namespace ISTEP_21
extern errlHndl_t callShutdown ( uint64_t i_hbInstance,
bool i_masterInstance,
const uint64_t i_commBase );
+ extern errlHndl_t enableCoreCheckstops();
extern errlHndl_t callCheckFreqAttrData(uint64_t freqData1, uint64_t freqData2);
};
@@ -468,13 +469,18 @@ void IpcSp::msgHandler()
if (err) break;
- if(!err)
+ err = ISTEP_21::enableCoreCheckstops();
+
+ if (err)
{
- // Function will not return unless error
- err = ISTEP_21::callShutdown(msg->data[0],false,
- msg->data[1]);
+ // Commit the error but continue to shutdown
+ errlCommit(err, IPC_COMP_ID);
}
+ // Function will not return unless error
+ err = ISTEP_21::callShutdown(msg->data[0],false,
+ msg->data[1]);
+
if(err)
{
uint32_t l_errPlid = err->plid();
OpenPOWER on IntegriCloud