Add consistent enter-exit traces for all runtime interfaces

Created a new 'HBRT' trace buffer that is exclusively used to
 bound the external calls into our runtime image.
Modified the return code values to be the reasoncode of the error
 log we commit instead of a generic '-1' value that is not
 very helpful.

Change-Id: Id41288ea1903bf6d11e967fcb10a8184153943c8
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/64871
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Reviewed-by: Brian J. Stegmiller <bjs@us.ibm.com>
Reviewed-by: Matt Derksen <mderkse1@us.ibm.com>
Reviewed-by: William G. Hoffa <wghoffa@us.ibm.com>

1 files changed, 12 insertions, 6 deletions

diff --git a/src/usr/isteps/pm/runtime/rt_pm.C b/src/usr/isteps/pm/runtime/rt_pm.C
index ef861563d..163a78b55 100644
--- a/src/usr/isteps/pm/runtime/rt_pm.C
+++ b/src/usr/isteps/pm/runtime/rt_pm.C
@@ -53,6 +53,7 @@
 using namespace TARGETING;
 using namespace RUNTIME;
 using namespace ERRORLOG;
+extern trace_desc_t* g_trac_hbrt;
 
 namespace ISTEPS_TRACE
 {
@@ -71,13 +72,12 @@ namespace RTPM
     void pm_complex_error( errlHndl_t i_err,
                            int &io_rc )
     {
-        errlCommit( i_err, RUNTIME_COMP_ID );
-
         if(io_rc == 0)
         {
-            io_rc = -1;
+            io_rc = ERRL_GETRC_SAFE(i_err);
         }
 
+        errlCommit( i_err, RUNTIME_COMP_ID );
         return;
     }
 
@@ -99,7 +99,7 @@ namespace RTPM
         errlHndl_t l_err = nullptr;
         int rc = 0;
 
-        TRACFCOMP( ISTEPS_TRACE::g_trac_isteps_trace,
+        TRACFCOMP( g_trac_hbrt,ENTER_MRK
                    "load_pm_complex: homer addr=%016llx. "
                    "occ common addr=%016lx. RtProcChip=%llx. mode=%d",
                    i_homer_addr,
@@ -193,6 +193,8 @@ namespace RTPM
                              rc);
         }
 
+        TRACFCOMP( g_trac_hbrt,EXIT_MRK
+                   "load_pm_complex:rc=0x%X", rc );
         return rc;
     }
 
@@ -208,7 +210,7 @@ namespace RTPM
         errlHndl_t l_err = nullptr;
         int rc = 0;
 
-        TRACFCOMP( ISTEPS_TRACE::g_trac_isteps_trace,
+        TRACFCOMP( g_trac_hbrt,ENTER_MRK
                    "start_pm_complex: RtProcChip %llx", i_chip);
 
         do
@@ -263,6 +265,8 @@ namespace RTPM
                              rc);
         }
 
+        TRACFCOMP( g_trac_hbrt,EXIT_MRK
+                   "start_pm_complex:rc=0x%X", rc );
         return rc;
     }
 
@@ -279,7 +283,7 @@ namespace RTPM
         errlHndl_t l_err = nullptr;
         int rc = 0;
 
-        TRACFCOMP( ISTEPS_TRACE::g_trac_isteps_trace,
+        TRACFCOMP( g_trac_hbrt,ENTER_MRK
                    "reset_pm_complex: RtProcChip %llx", i_chip);
 
         do
@@ -318,6 +322,8 @@ namespace RTPM
                              rc);
         }
 
+        TRACFCOMP( g_trac_hbrt,EXIT_MRK
+                   "reset_pm_complex:rc=0x%X", rc );
         return rc;
     }