diff options
author | Mike Jones <mjjones@us.ibm.com> | 2012-12-13 08:19:18 -0600 |
---|---|---|
committer | A. Patrick Williams III <iawillia@us.ibm.com> | 2012-12-13 15:37:59 -0600 |
commit | ca57ac8f1561d676497397d03f25bf942ea75b85 (patch) | |
tree | 5d4645a3576ddf75288acd5d8604fe5efefe024a /src/usr/hwpf/hwp/fapiTestHwpAttr.C | |
parent | fa8513c5a50a4632b21c7480f15a671b0cc62fdd (diff) | |
download | blackbird-hostboot-ca57ac8f1561d676497397d03f25bf942ea75b85.tar.gz blackbird-hostboot-ca57ac8f1561d676497397d03f25bf942ea75b85.zip |
HWPF Attr Override/Sync: Fix mailbox queue id and minor review updates
After merging the HWSV side of the HWPF Attr Override/Sync change. I
found that someone stole my queue ids. Updating the Hostboot code to
match. Also some minor changes to some FAPI files that Nick wanted
done after the HWSV review.
Change-Id: I6b3724ab2aa3234794112b098c74914b16e1a69a
Reviewed-on: http://gfw160.austin.ibm.com:8080/gerrit/2676
Tested-by: Jenkins Server
Reviewed-by: Brian H. Horton <brianh@linux.ibm.com>
Reviewed-by: A. Patrick Williams III <iawillia@us.ibm.com>
Diffstat (limited to 'src/usr/hwpf/hwp/fapiTestHwpAttr.C')
-rwxr-xr-x | src/usr/hwpf/hwp/fapiTestHwpAttr.C | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/src/usr/hwpf/hwp/fapiTestHwpAttr.C b/src/usr/hwpf/hwp/fapiTestHwpAttr.C index 0cee8edf5..ad01d43c0 100755 --- a/src/usr/hwpf/hwp/fapiTestHwpAttr.C +++ b/src/usr/hwpf/hwp/fapiTestHwpAttr.C @@ -997,11 +997,12 @@ fapi::ReturnCode hwpTestAttributes(fapi::Target & i_mbaTarget, if (l_pAttr[0].iv_val != 4) { FAPI_SET_HWP_ERROR(l_rc, RC_HWP_ATTR_UNIT_TEST_FAIL); - FAPI_ERR("hwpTestAttributes: Error. Got bad value (0x%llx) from tank (2.7)", + FAPI_ERR("hwpTestAttributes: Error. Got bad value (0x%016llx) from tank (2.7)", l_pAttr[0].iv_val); break; } delete [] l_attributes[0].iv_pAttributes; + l_attributes[0].iv_pAttributes = NULL; } //---------------------------------------------------------------------- @@ -1030,7 +1031,7 @@ fapi::ReturnCode hwpTestAttributes(fapi::Target & i_mbaTarget, if (l_val != 4) { FAPI_SET_HWP_ERROR(l_rc, RC_HWP_ATTR_UNIT_TEST_FAIL); - FAPI_ERR("hwpTestAttributes: Error. Got bad value (0x%llx) from tank (3.2)", + FAPI_ERR("hwpTestAttributes: Error. Got bad value (0x%016llx) from tank (3.2)", l_val); break; } @@ -1091,6 +1092,7 @@ fapi::ReturnCode hwpTestAttributes(fapi::Target & i_mbaTarget, } free (l_attributes[0].iv_pAttributes); + l_attributes[0].iv_pAttributes = NULL; } //---------------------------------------------------------------------- @@ -1182,6 +1184,7 @@ fapi::ReturnCode hwpTestAttributes(fapi::Target & i_mbaTarget, } free (l_attributes[0].iv_pAttributes); + l_attributes[0].iv_pAttributes = NULL; } } while (0); |