HWPF Attr Override/Sync: Fix mailbox queue id and minor review updates

After merging the HWSV side of the HWPF Attr Override/Sync change. I
found that someone stole my queue ids. Updating the Hostboot code to
match. Also some minor changes to some FAPI files that Nick wanted
done after the HWSV review.

Change-Id: I6b3724ab2aa3234794112b098c74914b16e1a69a
Reviewed-on: http://gfw160.austin.ibm.com:8080/gerrit/2676
Tested-by: Jenkins Server
Reviewed-by: Brian H. Horton <brianh@linux.ibm.com>
Reviewed-by: A. Patrick Williams III <iawillia@us.ibm.com>

1 files changed, 16 insertions, 1 deletions

diff --git a/src/usr/hwpf/fapi/fapiAttributeTank.C b/src/usr/hwpf/fapi/fapiAttributeTank.C
index 20f5fc081..a2f84f68d 100644
--- a/src/usr/hwpf/fapi/fapiAttributeTank.C
+++ b/src/usr/hwpf/fapi/fapiAttributeTank.C
@@ -43,6 +43,21 @@ namespace fapi
 {
 
 //******************************************************************************
+Attribute::Attribute() :
+    iv_val(0), iv_attrId(0), iv_targetType(0), iv_pos(0), iv_unitPos(0),
+    iv_flags(0), iv_arrayD1(0), iv_arrayD2(0), iv_arrayD3(0), iv_arrayD4(0)
+{
+
+}
+
+//******************************************************************************
+AttributeChunk::AttributeChunk() :
+    iv_numAttributes(0), iv_pAttributes(NULL)
+{
+
+}
+
+//******************************************************************************
 AttributeTank::AttributeTank() :
     iv_pName("AttributeTank"), iv_attributesExist(false)
 {
@@ -249,7 +264,7 @@ bool AttributeTank::getAttribute(const fapi::AttributeId i_attrId,
 
 //******************************************************************************
 void AttributeTank::getAllAttributes(
-    AllocType i_allocType,
+    const AllocType i_allocType,
     std::vector<AttributeChunk> & o_attributes) const
 {
     platLock();