diff options
| author | Christian Geddes <crgeddes@us.ibm.com> | 2018-11-19 12:26:21 -0600 |
|---|---|---|
| committer | Daniel M. Crowell <dcrowell@us.ibm.com> | 2018-11-26 23:10:26 -0600 |
| commit | f63977be6280c93b54d5b45e6fbccc8c44ec0b24 (patch) | |
| tree | 8e45326c5a94bac2c699a91b075bafa189893f2a /src/usr/expscom | |
| parent | 14dbbd68d03d2447254d21ad6426e472d102a817 (diff) | |
| download | blackbird-hostboot-f63977be6280c93b54d5b45e6fbccc8c44ec0b24.tar.gz blackbird-hostboot-f63977be6280c93b54d5b45e6fbccc8c44ec0b24.zip | |
Clean up typos/small things with expscom directory
A few comment typos were lingering in the new expscom module
directory. This commit addresses those typos and also removes and
Change-Id: If9c9692336591a7e0e57751676d76fd947add1cd
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/68915
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Reviewed-by: Matt Derksen <mderkse1@us.ibm.com>
Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
Diffstat (limited to 'src/usr/expscom')
| -rw-r--r-- | src/usr/expscom/README.md | 7 | ||||
| -rw-r--r-- | src/usr/expscom/expscom_utils.C | 8 | ||||
| -rw-r--r-- | src/usr/expscom/i2cscomdd.C | 3 |
3 files changed, 9 insertions, 9 deletions
diff --git a/src/usr/expscom/README.md b/src/usr/expscom/README.md index fd7e351e5..0710b49ce 100644 --- a/src/usr/expscom/README.md +++ b/src/usr/expscom/README.md @@ -150,12 +150,12 @@ targets will be processed (lets say for now this is IBM scom address): fapi2::getScom(myOcmbTarget, scomAddr, io_buffer); -* Platform Specifc FAPI2 getScom API +* Platform Specific FAPI2 getScom API fapi2::platGetScom(myOcmbTarget, scomAddr, io_buffer); -* Platform Specifc FAPI2 getScom API resolves to calling into our device framework to whatever +* Platform Specific FAPI2 getScom API resolves to calling into our device framework to whatever function is registered to read OCMB target for DeviceFW::SCOM operations @@ -241,7 +241,8 @@ for OCMB target scoms so we will end up calling doScomOp DeviceFW::MMIO, address, readLimit); -* mmioPerformOp resolves to doing a memcpy on the address requested +* mmioPerformOp will execute the actual load/store operation input memory-mapped i/o +space and handle errors in that operation if (i_opType == DeviceFW::READ) diff --git a/src/usr/expscom/expscom_utils.C b/src/usr/expscom/expscom_utils.C index a631f74e0..db2ff9dab 100644 --- a/src/usr/expscom/expscom_utils.C +++ b/src/usr/expscom/expscom_utils.C @@ -35,9 +35,9 @@ #include <errl/errlmanager.H> // errlCommit #include <errl/errludtarget.H> // ErrlUserDetailsTarget #include <devicefw/driverif.H> // OperationType -#include <expscom/expscom_reasoncodes.H> -#include "expscom_trace.H" -#include "expscom_utils.H" +#include <expscom/expscom_reasoncodes.H> // ReasonCodes/ModuleIds +#include "expscom_trace.H" //g_trac_expscom +#include "expscom_utils.H" //validateInputs namespace EXPSCOM { @@ -45,7 +45,7 @@ namespace EXPSCOM constexpr uint64_t FIRST_4_BYTES = 0xFFFFFFFF00000000; /////////////////////////////////////////////////////////////////////////////// -// See above for doxygen documentation +// See header file for doxygen documentation /////////////////////////////////////////////////////////////////////////////// errlHndl_t validateInputs(DeviceFW::OperationType i_opType, const TARGETING::Target* i_target, diff --git a/src/usr/expscom/i2cscomdd.C b/src/usr/expscom/i2cscomdd.C index 596e293ec..b58a70648 100644 --- a/src/usr/expscom/i2cscomdd.C +++ b/src/usr/expscom/i2cscomdd.C @@ -35,8 +35,7 @@ #include <lib/i2c/exp_i2c_scom.H> // i2c_get_scom #include <errl/errludtarget.H> // ErrlUserDetailsTarget #include <hwpf/fapi2/include/fapi2_hwp_executor.H> // FAPI_EXEC_HWP -#include <expscom/expscom_reasoncodes.H> // EXPSCOM::MOD_I2CSCOM_PERFORM_OP -#include "i2cscomdd.H" //i2cScomPerformOp +#include "i2cscomdd.H" //i2cScomPerformOp #include "expscom_trace.H" //g_trac_expscom #include "expscom_utils.H" //validateInputs |
