BEAM fixes in errlm, targeting, initservice, mvpd accessors, hwas, and mdia

Partial updates for issues 94995 Errlm, 94996 targeting, 94998 istep/initservice
94999 VPD accessors, 95000 HWAS, and 95001 MDIA.
Open issues require additional research: push_back memory leak, sync_cond_wait
infinite loop, masterCpu uninitialized complaint, checkConstantsMatch template
no effect, and shutdown has no effect. Issue will be updated with progress.

Change-Id: If60fef67564a0c2cb2a10824100480095e896f17
RTC: 94995
Reviewed-on: http://gfw160.aus.stglabs.ibm.com:8080/gerrit/9492
Tested-by: Jenkins Server
Reviewed-by: MIKE J. JONES <mjjones@us.ibm.com>
Reviewed-by: STEPHEN M. CPREK <smcprek@us.ibm.com>
Reviewed-by: A. Patrick Williams III <iawillia@us.ibm.com>

1 files changed, 5 insertions, 7 deletions

diff --git a/src/usr/errl/runtime/rt_errlmanager.C b/src/usr/errl/runtime/rt_errlmanager.C
index 6fb120168..9586afb24 100644
--- a/src/usr/errl/runtime/rt_errlmanager.C
+++ b/src/usr/errl/runtime/rt_errlmanager.C
@@ -5,7 +5,7 @@
 /*                                                                        */
 /* IBM CONFIDENTIAL                                                       */
 /*                                                                        */
-/* COPYRIGHT International Business Machines Corp. 2013                   */
+/* COPYRIGHT International Business Machines Corp. 2013,2014              */
 /*                                                                        */
 /* p1                                                                     */
 /*                                                                        */
@@ -123,12 +123,10 @@ void ErrlManager::sendMboxMsg ( errlHndl_t& io_err )
     TRACFCOMP( g_trac_errl, ENTER_MRK"ErrlManager::sendToHypervisor" );
     do
     {
+        uint32_t l_msgSize = io_err->flattenedSize();
 
-         uint32_t l_msgSize = io_err->flattenedSize();
-
-
-         void * temp_buff = malloc( l_msgSize );
-         io_err->flatten ( temp_buff, l_msgSize );
+        uint8_t * temp_buff = new uint8_t [l_msgSize ];
+        io_err->flatten ( temp_buff, l_msgSize );
 
         TRACDCOMP(g_trac_errl,
                   INFO_MRK"Send msg to FSP for errlogId [0x%08x]",
@@ -158,7 +156,7 @@ void ErrlManager::sendMboxMsg ( errlHndl_t& io_err )
                       );
         }
 
-        delete (uint8_t *)temp_buff;
+        delete [] temp_buff;
 
     } while (0);