diff options
| author | Zane Shelley <zshelle@us.ibm.com> | 2017-01-31 14:15:14 -0600 |
|---|---|---|
| committer | Zane C. Shelley <zshelle@us.ibm.com> | 2017-02-10 17:35:19 -0500 |
| commit | 48853801cd21f72f5e109c559ba8e60c7d28927b (patch) | |
| tree | 958a6efe8d0d74b978c24032efb6be53804b5661 /src/usr/diag/prdf/common/framework | |
| parent | 982dd4c4466b2589654c90823fd956ecfa8199f3 (diff) | |
| download | blackbird-hostboot-48853801cd21f72f5e109c559ba8e60c7d28927b.tar.gz blackbird-hostboot-48853801cd21f72f5e109c559ba8e60c7d28927b.zip | |
PRD: cleaned BitString::Mask()
This function had a off-by-one error that could access memory beyond
the available memory space.
Change-Id: I32e547c7238e3307f189334638c6239ea6940e62
RTC: 167819
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/35690
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Reviewed-by: Benjamin J. Weisenbeck <bweisenb@us.ibm.com>
Reviewed-by: Caleb N. Palmer <cnpalmer@us.ibm.com>
Reviewed-by: Zane C. Shelley <zshelle@us.ibm.com>
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/36203
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Diffstat (limited to 'src/usr/diag/prdf/common/framework')
| -rwxr-xr-x | src/usr/diag/prdf/common/framework/register/iipscr.C | 2 | ||||
| -rwxr-xr-x | src/usr/diag/prdf/common/framework/register/prdfErrorRegisterMask.C | 4 |
2 files changed, 3 insertions, 3 deletions
diff --git a/src/usr/diag/prdf/common/framework/register/iipscr.C b/src/usr/diag/prdf/common/framework/register/iipscr.C index 127992be5..bfc68ca33 100755 --- a/src/usr/diag/prdf/common/framework/register/iipscr.C +++ b/src/usr/diag/prdf/common/framework/register/iipscr.C @@ -120,7 +120,7 @@ uint32_t SCAN_COMM_REGISTER_CLASS::Read if(rc == SUCCESS) { BIT_STRING_CLASS & bitString = AccessBitString(); - bitString.Mask(mask); + bitString.maskString(mask); } return(rc); diff --git a/src/usr/diag/prdf/common/framework/register/prdfErrorRegisterMask.C b/src/usr/diag/prdf/common/framework/register/prdfErrorRegisterMask.C index 64aa10009..0c083d03e 100755 --- a/src/usr/diag/prdf/common/framework/register/prdfErrorRegisterMask.C +++ b/src/usr/diag/prdf/common/framework/register/prdfErrorRegisterMask.C @@ -110,14 +110,14 @@ const BIT_STRING_CLASS & ErrorRegisterMask::Read() scr_rc = scr.Read(); bitString = *scr.GetBitString(); // apply software mask - bitString.Mask(bitStringMask); + bitString.maskString(bitStringMask); // apply hardware mask - if scan comm register for it was specified if(&xMaskScr != NULL) /*constant condition*/ // dg00 { // dg00 int32_t rc = xMaskScr.Read(); // dg00 if(rc == SUCCESS) // dg00 { // dg00 - bitString.Mask(*(xMaskScr.GetBitString())); // dg00 + bitString.maskString(*(xMaskScr.GetBitString())); // dg00 } // dg00 } // dg00 |
