PRD: Data Storage exception in BitString class

We found a bug where a BitString object was used on an area of memory
that was not CPU_WORD aligned. This memory was also allocated at the
very end of a page and the next page was not accessible by Hostboot. So
as when the last CPU_WORD of the data was accessed it crossed over into
the unaccessible page and cause and exception.

Change-Id: I71e87aeb4feaea1ea977d3b396674073a3d03e7b
CQ: SW352432
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/35011
Reviewed-by: Brian J. Stegmiller <bjs@us.ibm.com>
Reviewed-by: Caleb N. Palmer <cnpalmer@us.ibm.com>
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Reviewed-by: Zane C. Shelley <zshelle@us.ibm.com>
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/35012
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>

1 files changed, 7 insertions, 7 deletions

diff --git a/src/usr/diag/prdf/common/framework/register/iipCaptureData.h b/src/usr/diag/prdf/common/framework/register/iipCaptureData.h
index 4395ce38b..b8aeac652 100755
--- a/src/usr/diag/prdf/common/framework/register/iipCaptureData.h
+++ b/src/usr/diag/prdf/common/framework/register/iipCaptureData.h
@@ -5,7 +5,7 @@
 /*                                                                        */
 /* OpenPOWER HostBoot Project                                             */
 /*                                                                        */
-/* Contributors Listed Below - COPYRIGHT 2012,2015                        */
+/* Contributors Listed Below - COPYRIGHT 2012,2017                        */
 /* [+] International Business Machines Corp.                              */
 /*                                                                        */
 /*                                                                        */
@@ -230,7 +230,7 @@ public:
    </ul><br>
    */
   void Add( TARGETING::TargetHandle_t i_pchipHandle, int scomId,
-            BIT_STRING_CLASS & bs, Place place = BACK);
+            const BIT_STRING_CLASS & bs, Place place = BACK);
 
   // dg02 end
 
@@ -338,11 +338,11 @@ private:
 
   DataContainerType             data;
 
-  /**
-   Private function to facilitate the adding of caputre data to the internal vector
-   */
-  void AddDataElement(Data &dataElement, SCAN_COMM_REGISTER_CLASS & scr, Place place, RegType type);
-  //$TEMP @jl04 Changed AddDataElement to include a Register type.
+    /** Private function to facilitate the adding of caputre data to the
+     *  internal vector */
+    void AddDataElement( TARGETING::TargetHandle_t i_trgt, int i_scomId,
+                         const BIT_STRING_CLASS * i_bs, Place i_place,
+                         RegType i_type = PRIMARY );
 
   // Predicate for deciding to delete an element of data from a Capture Data list.
   class prdfCompareCaptureDataType : public std::unary_function<Data &, bool>