Fix mailbox memory allocation error on attribute sync

Change-Id: If156faa95769b70731dc77f7b9801ff3ea743556
Reviewed-on: http://gfw160.austin.ibm.com:8080/gerrit/5239
Reviewed-by: Dean Sanner <dsanner@us.ibm.com>
Tested-by: Jenkins Server
Reviewed-by: A. Patrick Williams III <iawillia@us.ibm.com>

1 files changed, 8 insertions, 0 deletions

diff --git a/src/kernel/heapmgr.C b/src/kernel/heapmgr.C
index d2df127e9..4fdfded57 100644
--- a/src/kernel/heapmgr.C
+++ b/src/kernel/heapmgr.C
@@ -578,6 +578,14 @@ bool HeapManager::_freeBig(void* i_ptr)
         }
         bc = (big_chunk_t*) (((uint64_t)bc->next) & 0x00000000FFFFFFFF);
     }
+
+    // Small allocations are always aligned, hence we exited out at the
+    // beginning of the function.  Large allocations are always aligned.
+    // If we did not find a large allocation in the list (result == false)
+    // then either we have a double-free or someone trying to free something
+    // that doesn't belong on the heap.
+    crit_assert(result);
+
     return result;
 }