diff options
| author | Josh Rispoli <jprispol@us.ibm.com> | 2014-06-26 13:46:33 -0500 |
|---|---|---|
| committer | A. Patrick Williams III <iawillia@us.ibm.com> | 2014-07-14 13:56:03 -0500 |
| commit | 57cc498bd1d752d6f5ac0446f010f7b7e480597c (patch) | |
| tree | 05d5a1521efa6929d935555c16700047e1ca2c9f /src/kernel | |
| parent | 60958fcd0aab33fcb224e64e8723e24206b1df70 (diff) | |
| download | blackbird-hostboot-57cc498bd1d752d6f5ac0446f010f7b7e480597c.tar.gz blackbird-hostboot-57cc498bd1d752d6f5ac0446f010f7b7e480597c.zip | |
Revisit all daemon tasks and make sure they are properly daemonizing quickly
Added task_detach() to daemons not properly daemonizing
Added printk to alert when detached tasks crash
Change-Id: Ibc7567c7d61064627b3105f98c89c310fcfaa1c6
RTC:110382
Reviewed-on: http://gfw160.aus.stglabs.ibm.com:8080/gerrit/11829
Tested-by: Jenkins Server
Reviewed-by: Brian Silver <bsilver@us.ibm.com>
Reviewed-by: William H. Schwartz <whs@us.ibm.com>
Reviewed-by: A. Patrick Williams III <iawillia@us.ibm.com>
Diffstat (limited to 'src/kernel')
| -rw-r--r-- | src/kernel/taskmgr.C | 17 |
1 files changed, 14 insertions, 3 deletions
diff --git a/src/kernel/taskmgr.C b/src/kernel/taskmgr.C index 9569c7180..cb7e335dc 100644 --- a/src/kernel/taskmgr.C +++ b/src/kernel/taskmgr.C @@ -5,7 +5,9 @@ /* */ /* OpenPOWER HostBoot Project */ /* */ -/* COPYRIGHT International Business Machines Corp. 2010,2014 */ +/* Contributors Listed Below - COPYRIGHT 2010,2014 */ +/* [+] International Business Machines Corp. */ +/* */ /* */ /* Licensed under the Apache License, Version 2.0 (the "License"); */ /* you may not use this file except in compliance with the License. */ @@ -170,9 +172,18 @@ void TaskManager::_endTask(task_t* t, void* retval, int status) t->tracker->retval = retval; t->tracker->task = NULL; // NULL signifies task is complete for now. - if (t->detached) // If detached, just clean up the tracker. + if (t->detached) { - removeTracker(t->tracker); + if(status == TASK_STATUS_CRASHED) + { + printk("Critical: Detached task %d crashed.\n", + t->tid); + kassert(false); // Hostboot shuts down + } + else + { + removeTracker(t->tracker); + } } else // If not detached, do join. { |
