diff options
author | Andre Marin <aamarin@us.ibm.com> | 2017-02-08 11:48:50 -0600 |
---|---|---|
committer | Daniel M. Crowell <dcrowell@us.ibm.com> | 2017-02-11 21:41:00 -0500 |
commit | 3db9e21a6b52100763a3f8f4e2ad2ce47cd7f70e (patch) | |
tree | ce446eaab53419a1d122c4daeb731d368743b07c /src/import | |
parent | d04e4b84412e2330bedd0917fe608639e6b94245 (diff) | |
download | blackbird-hostboot-3db9e21a6b52100763a3f8f4e2ad2ce47cd7f70e.tar.gz blackbird-hostboot-3db9e21a6b52100763a3f8f4e2ad2ce47cd7f70e.zip |
Enable bad training bits workaround, always
The lab still is trying figure out what EC number this
needs to be enabled for. Until then we are running dirty.
Change-Id: I773e5bc0427e344a0b45c6140b0d1722437cf457
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/36180
Reviewed-by: Brian R. Silver <bsilver@us.ibm.com>
Dev-Ready: ANDRE A. MARIN <aamarin@us.ibm.com>
Reviewed-by: STEPHEN GLANCY <sglancy@us.ibm.com>
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: Hostboot CI <hostboot-ci+hostboot@us.ibm.com>
Reviewed-by: JACOB L. HARVEY <jlharvey@us.ibm.com>
Reviewed-by: Louis Stermole <stermole@us.ibm.com>
Reviewed-by: Jennifer A. Stofer <stofer@us.ibm.com>
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/36235
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
Diffstat (limited to 'src/import')
-rw-r--r-- | src/import/chips/p9/procedures/hwp/memory/lib/mss_attribute_accessors_manual.H | 8 |
1 files changed, 7 insertions, 1 deletions
diff --git a/src/import/chips/p9/procedures/hwp/memory/lib/mss_attribute_accessors_manual.H b/src/import/chips/p9/procedures/hwp/memory/lib/mss_attribute_accessors_manual.H index 87e3e52c9..078e7682d 100644 --- a/src/import/chips/p9/procedures/hwp/memory/lib/mss_attribute_accessors_manual.H +++ b/src/import/chips/p9/procedures/hwp/memory/lib/mss_attribute_accessors_manual.H @@ -235,7 +235,10 @@ fapi_try_exit: template< fapi2::TargetType T > inline bool chip_ec_feature_mss_training_bad_bits(const fapi2::Target<T>& i_target) { - // TODO RTC:165862 - need to get the minor EC number and check that in here. + // TODO RTC:168964 Enable training bad bits workaround at appropriate EC levels + // Running dirty until we know what EC major & minor number we want to add this to. + +#ifdef ALWAYS_DO_TRAINING_BAD_BITS_WORKAROUND const auto l_chip = mss::find_target<fapi2::TARGET_TYPE_PROC_CHIP>(i_target); uint8_t l_value = 0; uint8_t l_do_value = 0; @@ -251,6 +254,9 @@ fapi_try_exit: uint64_t(fapi2::current_err), mss::c_str(i_target)); fapi2::Assert(false); return false; +#else + return true; +#endif } /// |