diff options
| author | Bilicon Patil <bilpatil@in.ibm.com> | 2015-04-18 01:54:45 -0500 |
|---|---|---|
| committer | Patrick Williams <iawillia@us.ibm.com> | 2015-12-11 13:40:20 -0600 |
| commit | f88e09a2507b77ffacbf15caeec866259afffd44 (patch) | |
| tree | f214a0d7b004bcea3047f8d95254b4c659d9e6f7 /src/import/hwpf | |
| parent | 0f72dc07f6a676b6e6b572ed85a826bb087eecc7 (diff) | |
| download | blackbird-hostboot-f88e09a2507b77ffacbf15caeec866259afffd44.tar.gz blackbird-hostboot-f88e09a2507b77ffacbf15caeec866259afffd44.zip | |
FAPI_TRY will now add trace as an ERR type instead of DBG type.
Change-Id: Ib3232586d8355c216997ac0cc59bbb155345d479
Reviewed-on: http://gfw160.aus.stglabs.ibm.com:8080/gerrit/17299
Reviewed-by: Thi N. Tran <thi@us.ibm.com>
Reviewed-by: Matt K. Light <mklight@us.ibm.com>
Reviewed-by: Brian Silver <bsilver@us.ibm.com>
Tested-by: Brian Silver <bsilver@us.ibm.com>
Diffstat (limited to 'src/import/hwpf')
| -rwxr-xr-x | src/import/hwpf/fapi2/docs/topics/Examples.md | 4 | ||||
| -rw-r--r-- | src/import/hwpf/fapi2/include/fapi2_error_scope.H | 4 |
2 files changed, 2 insertions, 6 deletions
diff --git a/src/import/hwpf/fapi2/docs/topics/Examples.md b/src/import/hwpf/fapi2/docs/topics/Examples.md index e7ccb027d..09a38b57f 100755 --- a/src/import/hwpf/fapi2/docs/topics/Examples.md +++ b/src/import/hwpf/fapi2/docs/topics/Examples.md @@ -28,12 +28,12 @@ fapi2::buffer<uint8_t>(0xA5).flipBit<5>().flipBit<5>() == 0xA5; ## Operations and Things -### Is the FAPI_TRY / 'clean_up:' method, the recommended method for doing put/getscoms? +### Is the FAPI_TRY / 'fapi_try_exit:' method, the recommended method for doing put/getscoms? Yes, FAPI_TRY is the preferred wrapper for put/get scom as well as other operations which used to do the do/while/break dance based on the fapi return code. A thread-local fapi return code, fapi2::current_err has been introduced to help with the housekeeping. -Feel free to decompose the FAPI_TRY pattern if you have clean_up requirements which make FAPI_TRY too simplistic. +Feel free to decompose the FAPI_TRY pattern if you have clean up requirements which make FAPI_TRY too simplistic. ## Targets diff --git a/src/import/hwpf/fapi2/include/fapi2_error_scope.H b/src/import/hwpf/fapi2/include/fapi2_error_scope.H index c21e3b63c..43278c537 100644 --- a/src/import/hwpf/fapi2/include/fapi2_error_scope.H +++ b/src/import/hwpf/fapi2/include/fapi2_error_scope.H @@ -59,10 +59,6 @@ /// @param[in] ... vararg format/agruments for trace output (optional) /// @note This implementation does not support PIB error masks or /// FSP operational states. -/// @warning The trace information is only going to be seen during -/// debug, it's not an error or informational trace. This is because -/// traces might not be seen in the field. If you want information -/// you will see on a field error, use FAPI_ASSERT. /// #ifdef DOXYGEN #define FAPI_TRY(__operation__, ...) FAPI_TRY_IMPL |
