diff options
| author | Stephen Glancy <sglancy@us.ibm.com> | 2019-11-12 15:57:48 -0500 |
|---|---|---|
| committer | Daniel M Crowell <dcrowell@us.ibm.com> | 2019-11-14 10:22:47 -0600 |
| commit | 78426ddee158cfed3e45f837900aba01f1dd109d (patch) | |
| tree | 91c939f6e68f4c2b5e876cb4b06bcf1137992a6a | |
| parent | 06b4ead53152d4363fe153d48a06bf5aef6d3ed0 (diff) | |
| download | blackbird-hostboot-78426ddee158cfed3e45f837900aba01f1dd109d.tar.gz blackbird-hostboot-78426ddee158cfed3e45f837900aba01f1dd109d.zip | |
Disables broadcast mode in memdiags::continue_cmd
Broadcast mode at runtime can cause issues.
memdiags::continue_cmd is called at runtime,
so disabling the broadcast mode check will
fix an NVDIMM runtime bug.
Change-Id: Ib13ad0bf46c44aa26a6df39ffabc507348a1a14e
CQ:SW480744
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/86898
Reviewed-by: Mark Pizzutillo <mark.pizzutillo@ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: Hostboot CI <hostboot-ci+hostboot@us.ibm.com>
Reviewed-by: Louis Stermole <stermole@us.ibm.com>
Reviewed-by: Zane C Shelley <zshelle@us.ibm.com>
Reviewed-by: Caleb N Palmer <cnpalmer@us.ibm.com>
Reviewed-by: Jennifer A Stofer <stofer@us.ibm.com>
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/86912
Reviewed-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
Tested-by: Daniel M Crowell <dcrowell@us.ibm.com>
| -rw-r--r-- | src/import/generic/memory/lib/utils/mcbist/gen_mss_memdiags.H | 8 |
1 files changed, 6 insertions, 2 deletions
diff --git a/src/import/generic/memory/lib/utils/mcbist/gen_mss_memdiags.H b/src/import/generic/memory/lib/utils/mcbist/gen_mss_memdiags.H index dfb6b495b..efd2e9bd9 100644 --- a/src/import/generic/memory/lib/utils/mcbist/gen_mss_memdiags.H +++ b/src/import/generic/memory/lib/utils/mcbist/gen_mss_memdiags.H @@ -1103,8 +1103,12 @@ fapi2::ReturnCode continue_cmd( const fapi2::Target<T>& i_target, // Read-modify-write the fields in the program. FAPI_TRY( mss::getScom(i_target, TT::MCBAGRAQ_REG, l_program.iv_addr_gen) ); - // Configure broadcast mode if needed - FAPI_TRY(mss::mcbist::configure_broadcast_mode(i_target, l_program)); + // Note: we are specifically not configuring broadcast mode here + // The continue command is called by PRD exclusively at mainline + // If we're at mainline, we can't run in broadcast mode + // If we ever need to call continue elsewhere, we'll need to do the following + // 1) add the function to configure broadcast mode + // 2) add in a switch to disable broadcast mode if we're at runtime l_program.change_end_boundary(i_end); |
