summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorPrem Shanker Jha <premjha2@in.ibm.com>2019-09-13 00:10:41 -0500
committerChristian R Geddes <crgeddes@us.ibm.com>2019-09-27 13:46:25 -0500
commit1adf7486a2349d93775229d30c6361ee09a42d27 (patch)
tree7e0da8a7d0a61382ccc5464fb698f24e8b1037b3
parent746ec708f76a3e81145d18623ab5c535bd98f352 (diff)
downloadblackbird-hostboot-1adf7486a2349d93775229d30c6361ee09a42d27.tar.gz
blackbird-hostboot-1adf7486a2349d93775229d30c6361ee09a42d27.zip
PM: Modified FFDC to avoid corruption of RC in error path.
On FSP platform, in case of some errors, HWP captures certain EX level registers. To ensure availability of such registers, FSP first attempts special wakeup. Special wakeup HWP uses FAPI_TRY in its code path. It is known that in FFDC collection path, use of FAPI_TRY leads to corruption of original FAPI2 RC. Commit removes such registers from the capture list. Key_Cronus_Test=PM_REGRESS Change-Id: I23ce8b1a8a4a61f71c7b33c1122fcfac905616c4 CQ: SW471606 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/83863 Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Reviewed-by: Gregory S Still <stillgs@us.ibm.com> Tested-by: PPE CI <ppe-ci+hostboot@us.ibm.com> Tested-by: Hostboot CI <hostboot-ci+hostboot@us.ibm.com> Tested-by: HWSV CI <hwsv-ci+hostboot@us.ibm.com> Tested-by: Cronus HW CI <cronushw-ci+hostboot@us.ibm.com> Reviewed-by: RANGANATHPRASAD G. BRAHMASAMUDRA <prasadbgr@in.ibm.com> Reviewed-by: AMIT J. TENDOLKAR <amit.tendolkar@in.ibm.com> Reviewed-by: Jennifer A Stofer <stofer@us.ibm.com> Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/83958 Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Reviewed-by: Christian R Geddes <crgeddes@us.ibm.com>
-rw-r--r--src/import/chips/p9/procedures/xml/error_info/p9_sbe_check_master_stop15_errors.xml16
1 files changed, 5 insertions, 11 deletions
diff --git a/src/import/chips/p9/procedures/xml/error_info/p9_sbe_check_master_stop15_errors.xml b/src/import/chips/p9/procedures/xml/error_info/p9_sbe_check_master_stop15_errors.xml
index 4dee999b7..e2c010a53 100644
--- a/src/import/chips/p9/procedures/xml/error_info/p9_sbe_check_master_stop15_errors.xml
+++ b/src/import/chips/p9/procedures/xml/error_info/p9_sbe_check_master_stop15_errors.xml
@@ -5,7 +5,7 @@
<!-- -->
<!-- OpenPOWER HostBoot Project -->
<!-- -->
-<!-- Contributors Listed Below - COPYRIGHT 2015,2018 -->
+<!-- Contributors Listed Below - COPYRIGHT 2015,2019 -->
<!-- [+] International Business Machines Corp. -->
<!-- -->
<!-- -->
@@ -34,6 +34,8 @@
for a completed transition.
</description>
+ <ffdc>EX</ffdc>
+
<collectFfdc>p9_eq_clear_atomic_lock,EQ</collectFfdc>
<collectRegisterFfdc>
@@ -47,11 +49,6 @@
<targetType>TARGET_TYPE_EQ</targetType>
</collectRegisterFfdc>
<collectRegisterFfdc>
- <id>CHECK_MASTER_STOP15_FFDC_REGS_EX</id>
- <target>EX</target>
- <targetType>TARGET_TYPE_EX</targetType>
- </collectRegisterFfdc>
- <collectRegisterFfdc>
<id>CHECK_MASTER_STOP15_FFDC_REGS_EC</id>
<target>EC</target>
<targetType>TARGET_TYPE_CORE</targetType>
@@ -77,6 +74,8 @@
but the achieved level is not appropriate.
</description>
+ <ffdc>EX</ffdc>
+
<collectFfdc>p9_eq_clear_atomic_lock,EQ</collectFfdc>
<collectRegisterFfdc>
@@ -90,11 +89,6 @@
<targetType>TARGET_TYPE_EQ</targetType>
</collectRegisterFfdc>
<collectRegisterFfdc>
- <id>CHECK_MASTER_STOP15_FFDC_REGS_EX</id>
- <target>EX</target>
- <targetType>TARGET_TYPE_EX</targetType>
- </collectRegisterFfdc>
- <collectRegisterFfdc>
<id>CHECK_MASTER_STOP15_FFDC_REGS_EC</id>
<target>EC</target>
<targetType>TARGET_TYPE_CORE</targetType>
OpenPOWER on IntegriCloud