Build: Cleanup additional static analysis issues. (#230)

8 files changed, 6 insertions, 14 deletions

diff --git a/README.md b/README.md
index 8cce073..4360f79 100644
--- a/README.md
+++ b/README.md
@@ -1,3 +1,5 @@
+[![CodeFactor](https://www.codefactor.io/repository/github/meklort/bcm5719-fw/badge)](https://www.codefactor.io/repository/github/meklort/bcm5719-fw) [![Codacy Badge](https://app.codacy.com/project/badge/Grade/1714ef8c9b124be6a7f86c67cb63b63f)](https://www.codacy.com/gh/meklort/bcm5719-fw/dashboard?utm_source=github.com&utm_medium=referral&utm_content=meklort/bcm5719-fw&utm_campaign=Badge_Grade)
+
 # BCM5719 Firmware Reimplementation
 This project contains a clean-room reimplementation of the BCM5719 firmware based on the [Ortega](https://github.com/hlandau/ortega/blob/master/rtg-spec.md) specification.
 
diff --git a/build.sh b/build.sh
index f71b167..aa824a7 100755
--- a/build.sh
+++ b/build.sh
@@ -56,7 +56,7 @@ then
         if [ ! -x "$CMAKE" ]
         then
             echo "ERROR: Unable to locate cmake."
-            exit -1
+            exit 127
         fi
     fi
 fi
@@ -70,7 +70,7 @@ then
         if [ ! -x "$CPACK" ]
         then
             echo "ERROR: Unable to locate cpack."
-            exit -1
+            exit 127
         fi
     fi
 fi
diff --git a/include/bcm5719_eeprom.h b/include/bcm5719_eeprom.h
index 29f66fb..c0d4a6d 100644
--- a/include/bcm5719_eeprom.h
+++ b/include/bcm5719_eeprom.h
@@ -108,7 +108,6 @@ typedef struct {
     };
     #endif
     uint32_t    directoryOffset;    /*< NVRAM Offset to image */
-
 } NVRAMCodeDirectory_t;
 
 #define MANUFACTURING_INFORMATION_REVISION  ('A')
diff --git a/ipxact/regen.sh b/ipxact/regen.sh
index cd9fcc0..84f9015 100755
--- a/ipxact/regen.sh
+++ b/ipxact/regen.sh
@@ -54,10 +54,10 @@ mv APE_RX_PORT*.h ../include
 
 # ${IPXACT} -p ${PROJECT} NVIC.xml APE_full.xml APE.s
 ${IPXACT} -p ${PROJECT} APE_full.xml -t asym APE_sym.s
-mv *.s ../libs/bcm5719/
+mv ./*.s ../libs/bcm5719/
 
 ${IPXACT} -p ${PROJECT} APE_full.xml -t ape_cpp APE.cpp
 rm APE_APE*.cpp
 rm APE_SHM*.cpp
 rm APE_NVM*.cpp
-mv *.cpp ../simulator/
+mv ./*.cpp ../simulator/
diff --git a/libs/NCSI/tests/tests.cpp b/libs/NCSI/tests/tests.cpp
index 10dcb6a..ed24a52 100644
--- a/libs/NCSI/tests/tests.cpp
+++ b/libs/NCSI/tests/tests.cpp
@@ -195,8 +195,6 @@ void print_packet(uint32_t *packet_u32, size_t len)
             print_version(packet);
             break;
     }
-
-
 }
 
 void send_packet(uint8_t *packet, uint32_t len)
diff --git a/simulator/HAL.cpp b/simulator/HAL.cpp
index ab4fce4..701a8bd 100644
--- a/simulator/HAL.cpp
+++ b/simulator/HAL.cpp
@@ -211,7 +211,6 @@ static void locate_pci_path(int wanted_function, string &pci_path)
 
                 fclose(pConfigFile);
             }
-
         }
     }
 
diff --git a/utils/bcmflash/main.cpp b/utils/bcmflash/main.cpp
index 6e32edf..9f2a8f2 100644
--- a/utils/bcmflash/main.cpp
+++ b/utils/bcmflash/main.cpp
@@ -192,7 +192,6 @@ void dump_stage2(NVRAMStage2_t *stage2)
 
 void dump_code_directory(NVRAMCodeDirectory_t *cd, uint8_t *nvram, const char *outfile)
 {
-
     uint32_t info = be32toh(cd->codeInfo);
     if (info)
     {
@@ -705,7 +704,6 @@ int main(int argc, char const *argv[])
 
     if (extract)
     {
-
         if (!bcmflash_file_write("stage1.bin", stage1, stage1_length))
         {
             exit(-1);
diff --git a/utils/bcmregtool/main.cpp b/utils/bcmregtool/main.cpp
index 5eb2c4c..2a63334 100644
--- a/utils/bcmregtool/main.cpp
+++ b/utils/bcmregtool/main.cpp
@@ -396,7 +396,6 @@ int main(int argc, char const *argv[])
             cout << "Stepping...\n";
             step();
             print_context();
-
         } while (DEVICE.RxRiscProgramCounter.r32 > 0x40000000);
         exit(0);
     }
@@ -410,7 +409,6 @@ int main(int argc, char const *argv[])
 
             step();
             print_context();
-
         } while (DEVICE.RxRiscProgramCounter.r32 != addr);
         exit(0);
     }
@@ -615,7 +613,6 @@ int main(int argc, char const *argv[])
 
     if (options.get("apereset"))
     {
-
         // Halt
         RegAPEMode_t mode;
         mode.r32 = 0;
@@ -645,7 +642,6 @@ int main(int argc, char const *argv[])
     }
     if (options.get("reset"))
     {
-
         DEVICE.MiscellaneousConfig.bits.GRCReset = 1;
         exit(0);
     }