blob: 63b08f6f9a9a4638e89e11f4dade7b78ec165512 (
plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
|
// RUN: $(dirname %s)/check_clang_tidy_fix.sh %s misc-redundant-smartptr-get %t
// REQUIRES: shell
// CHECK-MESSAGES-NOT: warning
namespace std {
template <typename T>
class unique_ptr {
T& operator*() const;
T* operator->() const;
T* get() const;
};
template <typename T>
class shared_ptr {
T& operator*() const;
T* operator->() const;
T* get() const;
};
} // namespace std
struct Bar {
void Do();
void ConstDo() const;
};
struct BarPtr {
Bar* operator->();
Bar& operator*();
Bar* get();
};
struct int_ptr {
int* get();
int* operator->();
int& operator*();
};
struct Fail1 {
Bar* get();
};
struct Fail2 {
Bar* get();
int* operator->();
int& operator*();
};
void Positive() {
BarPtr u;
// CHECK-FIXES: BarPtr u;
BarPtr().get()->Do();
// CHECK-MESSAGES: :[[@LINE-1]]:3: warning: Redundant get() call on smart pointer. [misc-redundant-smartptr-get]
// CHECK-MESSAGES: BarPtr().get()->Do();
// CHECK-FIXES: BarPtr()->Do();
u.get()->ConstDo();
// CHECK-MESSAGES: :[[@LINE-1]]:3: warning: Redundant get() call on smart pointer.
// CHECK-MESSAGES: u.get()->ConstDo();
// CHECK-FIXES: u->ConstDo();
Bar& b = *BarPtr().get();
// CHECK-MESSAGES: :[[@LINE-1]]:13: warning: Redundant get() call on smart pointer.
// CHECK-MESSAGES: Bar& b = *BarPtr().get();
// CHECK-FIXES: Bar& b = *BarPtr();
Bar& b2 = *std::unique_ptr<Bar>().get();
// CHECK-MESSAGES: :[[@LINE-1]]:14: warning: Redundant get() call on smart pointer.
// CHECK-MESSAGES: Bar& b2 = *std::unique_ptr<Bar>().get();
// CHECK-FIXES: Bar& b2 = *std::unique_ptr<Bar>();
(*BarPtr().get()).ConstDo();
// CHECK-MESSAGES: :[[@LINE-1]]:5: warning: Redundant get() call on smart pointer.
// CHECK-MESSAGES: (*BarPtr().get()).ConstDo();
// CHECK-FIXES: (*BarPtr()).ConstDo();
(*std::unique_ptr<Bar>().get()).ConstDo();
// CHECK-MESSAGES: :[[@LINE-1]]:5: warning: Redundant get() call on smart pointer.
// CHECK-MESSAGES: (*std::unique_ptr<Bar>().get()).ConstDo();
// CHECK-FIXES: (*std::unique_ptr<Bar>()).ConstDo();
std::unique_ptr<Bar>* up;
(*up->get()).Do();
// CHECK-MESSAGES: :[[@LINE-1]]:5: warning: Redundant get() call on smart pointer.
// CHECK-MESSAGES: (*up->get()).Do();
// CHECK-FIXES: (**up).Do();
int_ptr ip;
int i = *ip.get();
// CHECK-MESSAGES: :[[@LINE-1]]:12: warning: Redundant get() call on smart pointer.
// CHECK-MESSAGES: int i = *ip.get();
// CHECK-FIXES: int i = *ip;
std::unique_ptr<int> uu;
std::shared_ptr<double> *ss;
bool bb = uu.get() == nullptr;
// CHECK-MESSAGES: :[[@LINE-1]]:13: warning: Redundant get() call on smart pointer.
// CHECK-MESSAGES: uu.get() == nullptr;
// CHECK-FIXES: bool bb = uu == nullptr;
bb = nullptr != ss->get();
// CHECK-MESSAGES: :[[@LINE-1]]:19: warning: Redundant get() call on smart pointer.
// CHECK-MESSAGES: nullptr != ss->get();
// CHECK-FIXES: bb = nullptr != *ss;
}
// CHECK-MESSAGES-NOT: warning:
void Negative() {
struct NegPtr {
int* get();
int* operator->() {
return &*this->get();
}
int& operator*() {
return *get();
}
};
std::unique_ptr<Bar>* u;
u->get()->Do();
Fail1().get()->Do();
Fail2().get()->Do();
const Bar& b = *Fail1().get();
(*Fail2().get()).Do();
int_ptr ip;
bool bb = std::unique_ptr<int>().get() == NULL;
bb = ip.get() == nullptr;
bb = u->get() == NULL;
}
|
